Fix unit test build #110
Merged
Fix unit test build #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reinstate the move of utils::change() to be an inline function similar to commit 467955d. This allows utils.h to be used in both the Linux and STM32 builds. Currently utils.cpp is highly platform specific and cannot be built for Linux x86. Tests: - Build for STM32 and x86 Linux - Run unit tests on Linux successfully
davefiddes
requested review from
damienmaguire and
jsphuebner
as code owners
Merged
damienmaguire
approved these changes
Sep 26, 2024
|
Thanks Dave |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reinstate the move of utils::change() to be an inline function similar to commit 467955d. This allows
utils.h to be used in both the Linux and STM32 builds. Currently utils.cpp is highly platform specific and cannot be built for Linux x86.
Tests: