Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disables WikipediaConverterIntegrationTest that fails on Wikipedia connection #189

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Disables WikipediaConverterIntegrationTest that fails on Wikipedia connection #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/test/java/pl/szczepanik/silencio/integration/WikipediaConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ public Value convert(Key key, Value value) {
if (newValue != null) {
return new Value(newValue);
} else {
// this loop theoretically may never ends but Wikipedia has millions of words to ask for
// so practically it make slows down for a while but should not hang
// this loop theoretically may never end but Wikipedia has millions of words to ask for,
// so practically it makes slows down for a while but should not hang
do {
newValue = generateNextString();
// check if this word was not generated for other key
Expand Down
2 changes: 2 additions & 0 deletions src/test/java/pl/szczepanik/silencio/integration/WikipediaConverterIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

import java.io.StringWriter;

import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import pl.szczepanik.silencio.GenericTest;
import pl.szczepanik.silencio.api.Format;
Expand All @@ -18,6 +19,7 @@
class WikipediaConverterIntegrationTest extends GenericTest {

@Test
@Disabled("Sometimes Wikipedia refuses connection when many requests are started one by one")
void shouldGetWordsFromWikipedia() {
// WARNING: this test fail when internet connection is not available

Expand Down