Disables WikipediaConverterIntegrationTest that fails on Wikipedia co…

…nnection (#189)
damianszczepanik · Jan 9, 2024 · 25bafb3 · 25bafb3
1 parent ade37ec
commit 25bafb3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/test/java/pl/szczepanik/silencio/integration/WikipediaConverter.java b/src/test/java/pl/szczepanik/silencio/integration/WikipediaConverter.java
@@ -47,8 +47,8 @@ public Value convert(Key key, Value value) {
         if (newValue != null) {
             return new Value(newValue);
         } else {
-            // this loop theoretically may never ends but Wikipedia has millions of words to ask for
-            // so practically it make slows down for a while but should not hang
+            // this loop theoretically may never end but Wikipedia has millions of words to ask for,
+            // so practically it makes slows down for a while but should not hang
             do {
                 newValue = generateNextString();
                 // check if this word was not generated for other key

diff --git a/src/test/java/pl/szczepanik/silencio/integration/WikipediaConverterIntegrationTest.java b/src/test/java/pl/szczepanik/silencio/integration/WikipediaConverterIntegrationTest.java
@@ -4,6 +4,7 @@
 
 import java.io.StringWriter;
 
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 import pl.szczepanik.silencio.GenericTest;
 import pl.szczepanik.silencio.api.Format;
@@ -18,6 +19,7 @@
 class WikipediaConverterIntegrationTest extends GenericTest {
 
     @Test
+    @Disabled("Sometimes Wikipedia refuses connection when many requests are started one by one")
     void shouldGetWordsFromWikipedia() {
         // WARNING: this test fail when internet connection is not available