Escaping input and output paths using double quotes #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Puts double quotes around input and output paths so that it paths with characters like spaces in them don't cause problems.
Fix so paths with characters like spaces are parsed correctly for crucial metadata (like video size and aspect ratio) and don't default to zero.
|
There is probably a better approach to this but had to fork and patch it fairly quickly as we need something that works now. :) Understand if you'd rather patch the issue of input and output paths with spaces not being handled with a more considered approach but would really appreciate the bug itself being fixed in master. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puts double quotes around input and output paths so that it paths with characters like spaces in them don't cause problems.