Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In preparation for aerosols, some cleanup of the warm microphysics.
field_r
's. When using FP32, all computations should now actually be done in FP32.Tests
Used the benchmnark/rico case for testing. Started from a 24 hour warm start, then simulated another hour. Here are some plots of the different
qr
tendencies:I think it would be a good idea to have someone who knows the microphysics go over the parameters, since modmicrodata has become very messy over the years.
@fjansson anything else that should be done?