Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev fix genstat #115

Merged
merged 4 commits into from
Sep 5, 2024
Merged

Dev fix genstat #115

merged 4 commits into from
Sep 5, 2024

Conversation

fjansson
Copy link
Contributor

@fjansson fjansson commented Sep 4, 2024

  • don't access svs field of surface scalar values (not always initialized, not needed anyway)
  • calculate hur, plw, pli, clw, cli also for k=1
  • don't calculate plw, pli if nsv <=1 i.e. the rain field is not present (todo: nicer condition)

CasparJungbacker
CasparJungbacker approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@CasparJungbacker CasparJungbacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fjansson fjansson merged commit e3fea4b into dev Sep 5, 2024
50 checks passed
@fjansson fjansson deleted the dev-fix-genstat branch September 5, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CasparJungbacker CasparJungbacker CasparJungbacker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fjansson @CasparJungbacker