Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OpenACC directives in 5th and 6th advection schemes #112

Merged
merged 5 commits into from
Sep 2, 2024
Merged

Add OpenACC directives in 5th and 6th advection schemes #112

merged 5 commits into from
Sep 2, 2024

Conversation

esclapez
Copy link
Collaborator

  • removing the rho_time_a_in array in 6th order
  • some formatting to make it easier to read the stencils

CasparJungbacker
CasparJungbacker approved these changes Sep 2, 2024
View reviewed changes
Copy link
Collaborator

@CasparJungbacker CasparJungbacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fjansson
fjansson approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@fjansson fjansson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • removing rho_a_in
  • getting the special k cases out of the k-loop
  • / dzf(k) -> * dzfi(k)
    these are good also in general / on CPU.
    Thanks!

@fjansson fjansson merged commit 025d602 into dev Sep 2, 2024
50 checks passed
@esclapez esclapez deleted the advHO_OpenACC branch September 10, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CasparJungbacker CasparJungbacker CasparJungbacker approved these changes

@fjansson fjansson fjansson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@esclapez @fjansson @CasparJungbacker