Fixes for running with open boundary conditions over land #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For using higher-order advection schemes which need more neighbor points. The ghost cell planes further away are filled with the same values as the origininal single plane.
fjansson
force-pushed
the
dev-ruisdael-fixes
branch
from
2b4322d
to
8b5706a
Compare
found by Frans Liqui Lung
found by Frans Liqui Lung With open boundaries, u,v,w need some boundary cells to be time-stepped: u0(i2,j,k), v0(i,j2,k) and w0(i,j,k1)
esclapez
reviewed
Aug 19, 2024
start loops from i=2, not 1. starting point adjusted for consistency with j and a bit less work, otherwise no practical difference. loop end point extended to j2 only when open boundaries are enabled and only on the MPI tiles where it's needed.
fjansson
force-pushed
the
dev-ruisdael-fixes
branch
from
ca5a6ec
to
5793349
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
land surface model: fix sign of rain flux, add some limits and diagnostics.
microphysics: run only up to kmax. If microphysics is done at k1, and open boundaries keep the k1 layer raining, it can form an "infinite" rain source, since cloud water is not removed from k1.
modgenstat: don't use
halflev_kappawith open boundaries, because it can cause out-of bounds accesses at the top when w != 0. This change only affects statistics, not the time stepping.