Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for OpenACC #107

Merged
merged 6 commits into from
Aug 9, 2024
Merged

Fixes for OpenACC #107

merged 6 commits into from
Aug 9, 2024

Conversation

esclapez
Copy link
Collaborator

@esclapez esclapez commented Aug 8, 2024

  • a fix in the genstat that was leading to occasional FP error on GPU
  • a fix in the warm restart on GPU that was leading to loosing the MPI rank <-> GPU pairing.

CasparJungbacker
CasparJungbacker approved these changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@CasparJungbacker CasparJungbacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! That modgenstat issue was really annoying, couldn't find it myself 😅

@esclapez esclapez merged commit c4b414a into dev Aug 9, 2024
50 checks passed
@esclapez esclapez deleted the fixGenStat branch August 9, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CasparJungbacker CasparJungbacker CasparJungbacker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esclapez @CasparJungbacker