Dev micro limiter fix #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qr < 0 after microphysics was handled by decreasing qt and increasing thl. This would be fine to un-do a too strong microphysics tendency, but deals poorly with undershoots from qr advection. Running with 2nd order qr advection led to crash with qt<0 and temperature above boiling point. This commit disables the correction (simpleice2, bulk microphysics) and instead introduces a lower cap qr,Nr >= 0.
|
there's probably an error still in modgenstat, some statistics (at least pli, plw, cli, clw) are not calculated for the lowest layer. Line 707 in d9b261d |
|
LGTM 👍 |
CasparJungbacker
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change handling of negative qr - don't attempt to correct it with qt and thl adjustments.
Also correct plw, pli stats in genstat (used the wrong field).