fix: update subscription tracking #2461
Conversation
rebelchris
requested review from
omBratteng,
ilasw,
sshanzel,
nensidosari and
AmarTrebinjac
src/routes/webhooks/paddle.ts
Outdated
| const userId = await getUserId({ | ||
| userId: customData?.user_id, | ||
| subscriptionId: 'subscriptionId' in data.data && data.data.subscriptionId, | ||
| }); | ||
| const con = await createOrGetConnection(); | ||
| const flags = await con.getRepository(User).findOne({ | ||
| where: { id: userId }, | ||
| select: ['subscriptionFlags'], | ||
| }); |
There was a problem hiding this comment.
We double query the user, once in getUserId then again in the call in this function?
There was a problem hiding this comment.
If we want to abstract anything maybe better that getUserId is just getUser and then we get user object either way which we can use.
There was a problem hiding this comment.
Yeah was thinking of that as well, just meant more refactors on end type as it's a optional return.
There was a problem hiding this comment.
Also the early return only cares about returning the id
There was a problem hiding this comment.
Alternative could be to have a seperate function for this case? (only 1 user now, but maybe future more)
Let me know if you prefer that
There was a problem hiding this comment.
I would just do it inline in both places but if we use util then I would go with getUser. Neither blocking for this PR.
Co-authored-by: Ante Barić <[email protected]>
We should only fire the event if subscription cycle actually changed, not any of the other changes.
I also decided to update our flags in this case so we have the right setting stored at all times.
AS-744 #done