fix: rejection reason note (#2480)

Rejection notification should now add the message.
dailydotdev · Nov 22, 2024 · 88a123a · 88a123a
1 parent 7734a9a
commit 88a123a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/__tests__/notifications/index.ts b/__tests__/notifications/index.ts
@@ -1324,6 +1324,8 @@ describe('storeNotificationBundle', () => {
       sourceId: 'a',
       createdById: '2',
       status: SourcePostModerationStatus.Rejected,
+      rejectionReason: 'Other',
+      moderatorMessage: 'Lacks value.',
     });
     const type = NotificationType.SourcePostRejected;
     const ctx: NotificationPostModerationContext = {
@@ -1343,9 +1345,9 @@ describe('storeNotificationBundle', () => {
     expect(actual.notification.referenceId).toEqual(post.id);
     expect(actual.notification.referenceType).toEqual('post_moderation');
     expect(actual.notification.title).toEqual(
-      'Your post in A was not approved for the following reason: null. Please review the feedback and consider making changes before resubmitting.',
+      'Your post in A was not approved for the following reason: Other. Please review the feedback and consider making changes before resubmitting.',
     );
-    expect(actual.notification.description).toBeFalsy();
+    expect(actual.notification.description).toEqual('Lacks value.');
     expect(actual.notification.targetUrl).toEqual(
       'http://localhost:5002/squads/a/moderate',
     );

diff --git a/src/notifications/generate.ts b/src/notifications/generate.ts
@@ -168,6 +168,7 @@ export const generateNotificationMap: Record<
       .icon(NotificationIcon.Bell)
       .referencePostModeration(ctx.post)
       .targetSourceModeration(ctx.source)
+      .description(ctx.post.moderatorMessage ?? '')
       .avatarSource(ctx.source),
   source_post_submitted: (builder, ctx: NotificationPostModerationContext) =>
     builder