-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New BFS method for use in asset backfills #26751
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple questions about the partition sort key fn
python_modules/dagster/dagster_tests/asset_defs_tests/asset_graph_view_tests/test_bfs.py
Show resolved
Hide resolved
python_modules/dagster/dagster_tests/asset_defs_tests/asset_graph_view_tests/test_bfs.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be useful to add a test that makes sure things don't get weird with self-dependent assets -- just by inspection I have no reason to believe it wouldn't work properly, but always nice to test the "hard" cases
|
Summary: Pulling out the new BFS utility added in #25997 to its own function with its own tests to keep the PR size manageable. Test Plan: New tests NOCHANGELOG
> Insert changelog entry or delete this section.
> Insert changelog entry or delete this section.
Summary:
Pulling out the new BFS utility added in #25997 to its own function with its own tests to keep the PR size manageable.
Test Plan: New tests
NOCHANGELOG
Summary & Motivation
How I Tested These Changes
Changelog