Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[utils] add beta warning and decorator #26748

Open
wants to merge 2 commits into
base: maxime/ad-735/add-preview-annotation
Choose a base branch
from

Conversation

maximearmstrong
Copy link
Contributor

@maximearmstrong maximearmstrong commented Dec 27, 2024

Summary & Motivation

Fixes AD-736 in the API Lifecycle project.

Adding new Beta Python utils. Similar to #25363

This is done in alignment with the new API lifecycle.

The raised warning is a Warning.

Docs to be updated in subsequent PR.

Copy link
Contributor Author

maximearmstrong commented Dec 27, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@maximearmstrong maximearmstrong force-pushed the maxime/ad-736/add-beta-annotation branch from 351fbe0 to 5f95dcf Compare December 27, 2024 21:15
@maximearmstrong maximearmstrong self-assigned this Dec 27, 2024
@maximearmstrong maximearmstrong marked this pull request as ready for review December 27, 2024 21:20
return

warnings.warn(
f"{subject} is in beta stage - the feature is still being tested and may change."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems ok - take it or leave it

is in beta stage - the feature is being tested for production readiness and may be updated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

is in beta. It may break in a future minor release, or have minor behavior changes between dot releases.

I don't love this "production readiness" framing, as I think the key important detail here is when / how likely this feature is to be broken, and what those breakages might look like

In my mind:

  • preview: might break even between dot releases
  • beta: might break on a dot release, or have behavior changes

Copy link
Contributor

@OwenKephart OwenKephart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants