Remove asset key iteration from backfill daemon, part 2 #26727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor > Insert changelog entry or delete this section. moar refactor > Insert changelog entry or delete this section. subsets instead of values > Insert changelog entry or delete this section. more progress on subsets instead of values > Insert changelog entry or delete this section. more progress > Insert changelog entry or delete this section. yet more progress > Insert changelog entry or delete this section. more progress > Insert changelog entry or delete this section. more > Insert changelog entry or delete this section. renames > Insert changelog entry or delete this section. final names? > Insert changelog entry or delete this section.
> Insert changelog entry or delete this section.
gibsondan
requested review from
OwenKephart,
clairelin135 and
jamiedemaria
and removed request for
OwenKephart
clairelin135
approved these changes
Dec 27, 2024
| ) -> "AssetBackfillData": | ||
| requested_partitions = get_requested_asset_partitions_from_run_requests( | ||
| requested_partitions = _get_requested_asset_graph_subset_from_run_requests( |
There was a problem hiding this comment.
nit: rename requested_partitions to requested_subset
| @@ -1467,16 +1440,16 @@ def execute_asset_backfill_iteration_inner( | |||
| RemoteWorkspaceAssetGraph, asset_graph_view.asset_graph | |||
| ) | |||
|
|
|||
| initial_candidates: Set[AssetKeyPartitionKey] = set() | |||
| initial_asset_graph_subset: AssetGraphSubset = AssetGraphSubset.empty() | |||
There was a problem hiding this comment.
consider naming this candidate_asset_graph_subset?
> Insert changelog entry or delete this section.
gibsondan
force-pushed
the
bfsreal
branch
4 times, most recently
from
b93ead9 to
41e786b
Compare
gibsondan
force-pushed
the
bfsreal
branch
2 times, most recently
from
b7b5a2e to
43b9cdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Clears out the other places in the asset backfill daemon where we were iterating through AssetKeyPartitionKeys, in favor of using AssetGraphSubsets.
How I Tested These Changes
BK
Changelog
NOCHANGELOG