-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[dagster-k8s] per_step_k8s_config working with dynamic jobs (#26670)
## Summary & Motivation Allow run time configuration of dynamic steps using the `k8s_job_executor`. Previously, dynamic steps would not be configured when using `per_step_k8s_config`. Now doing something along line of the following: ```yml execution: config: per_step_k8s_config: dyn_sink: container_config: resources: requests: cpu: '300m' ``` Given the following job: ```python @job def dynamic_producer_consumer_job(): @op(out=DynamicOut(int)) def dyn_producer(): yield from (DynamicOutput(i, str(i)) for i in range(3)) @op def dyn_sink(producer: int): ... ``` Will configure **all** `dyn_sink` ops with the following modified config. cc @Kuhlwein resolves #26588 ## How I Tested These Changes Red green coverage given a dynamic job. Revert the following [line](https://github.com/dagster-io/dagster/pull/26670/files#diff-e1b8a7f982ea59869272b4bc9529eab7f62d9474f250298d01d9a1ef68a537fbR243) to watch the test fail. # CHANGELOG - [dagster-k8s] k8s_job_executor supports per step configuration for dynamic steps.
- Loading branch information
1 parent
f158a04
commit bc84a5a
Showing
2 changed files
with
91 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters