Skip to content

Commit

Permalink
require symfony forms, move to yaml extension
Browse files Browse the repository at this point in the history
  • Loading branch information
solverat committed Aug 30, 2023
1 parent e4f1f9b commit 6e2f599
Show file tree
Hide file tree
Showing 85 changed files with 63 additions and 348 deletions.
3 changes: 2 additions & 1 deletion UPGRADE.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
# Upgrade Notes

## Migrating from Version 4.x to Version 5.0
- Execute: `bin/console doctrine:migrations:migrate --prefix 'FormBuilderBundle\Migrations'`

### Global Changes
- Recommended folder structure by symfony adopted
- [FUNNEL] Route include changed from `@FormBuilderBundle/Resources/config/pimcore/routing_funnels.yml` to `@FormBuilderBundle/config/pimcore/routing_funnels.yml`
- [FUNNEL] Route include changed from `@FormBuilderBundle/Resources/config/pimcore/routing_funnels.yml` to `@FormBuilderBundle/config/pimcore/routing_funnels.yaml`

### New Features
TBD
Expand Down
1 change: 1 addition & 0 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
"require": {
"php": "^8.2",
"pimcore/pimcore": "^11.0",
"symfony/form": "^6.0",
"doctrine/orm": "^2.7"
},
"require-dev": {
Expand Down
File renamed without changes.
7 changes: 3 additions & 4 deletions config/pimcore/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,6 @@ form_builder:
type: workflow_select
label: 'form_builder_output_workflow_select'
imports:
- { resource: '../backend/base_config.yml' }
- { resource: '../types/field_types.yml' }
- { resource: '../types/container_types.yml' }
- { resource: '../extension/extension.yml' }
- { resource: '../backend/base_config.yaml' }
- { resource: '../types/field_types.yaml' }
- { resource: '../types/container_types.yaml' }
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
7 changes: 7 additions & 0 deletions config/services.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
imports:
- { resource: services/conditional_logic/*.yaml }
- { resource: services/mail_editor/*.yaml }
- { resource: services/output_workflow/*.yaml }
- { resource: services/forms/*.yaml }
- { resource: services/transformer/*.yaml }
- { resource: services/*.yaml }
7 changes: 0 additions & 7 deletions config/services.yml

This file was deleted.

File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
2 changes: 2 additions & 0 deletions config/types/field_types.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
imports:
- { resource: type/*.yaml }
2 changes: 0 additions & 2 deletions config/types/field_types.yml

This file was deleted.

File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
4 changes: 2 additions & 2 deletions docs/OutputWorkflow/40_Funnels.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,11 @@ Don't freak out, we're talking about one tiny route only:
```yaml
# config/routes.yaml
form_builder_routing_funnels:
resource: '@FormBuilderBundle/config/pimcore/routing_funnels.yml'
resource: '@FormBuilderBundle/config/pimcore/routing_funnels.yaml'

# or import routes without the {locale} flag in routes
# form_builder_routing_funnels:
# resource: '@FormBuilderBundle/config/pimcore/routing_funnels_not_localized.yml'
# resource: '@FormBuilderBundle/config/pimcore/routing_funnels_not_localized.yaml'
```

## Further Information
Expand Down
2 changes: 1 addition & 1 deletion src/Controller/Admin/ExportController.php
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public function exportFormAction(Request $request, ImportExportProcessor $import
}

$response = new Response($data);
$exportName = 'form_export_' . $formId . '.yml';
$exportName = 'form_export_' . $formId . '.yaml';

$disposition = $response->headers->makeDisposition(
ResponseHeaderBag::DISPOSITION_ATTACHMENT,
Expand Down
2 changes: 1 addition & 1 deletion src/DependencyInjection/FormBuilderExtension.php
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public function load(array $configs, ContainerBuilder $container): void
$config = $this->processConfiguration($configuration, $configs);

$loader = new YamlFileLoader($container, new FileLocator([__DIR__ . '/../../config']));
$loader->load('services.yml');
$loader->load('services.yaml');

$conditionalLogicDefinition = $container->getDefinition(ConditionalLogicRegistry::class);

Expand Down
111 changes: 0 additions & 111 deletions src/Migrations/Version20211011171530.php

This file was deleted.

30 changes: 0 additions & 30 deletions src/Migrations/Version20211208110858.php

This file was deleted.

52 changes: 0 additions & 52 deletions src/Migrations/Version20221121130120.php

This file was deleted.

32 changes: 0 additions & 32 deletions src/Migrations/Version20230303094642.php

This file was deleted.

Loading

0 comments on commit 6e2f599

Please sign in to comment.