Speed up signing many bitcoin cash inputs #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rynomster
changed the title
rynomster
changed the title
|
It would be much better to encode the values into the unsigned transaction when generating the unsigned raw transaction and just deserializing the values from the pasted hex. Since I really don't want to spend much more time on Cash support, it will be a while before I can test and merge this. If you would like to change the raw transaction serializer to encode input value (maybe add it in after each of the prevOut data in each input) into the raw transaction and let the signing function decode that, I would definitely look into testing and merging, but as is, this is a small performance increase for an edge case on a project I'm not very invested in anymore... so it may take time for me to get around to it. |
|
No worries.. I just thought I'd do a PR because I had to use it to send
funds to a new address. It went from more than a minute to sign to a few
seconds. I'm also not really interested in working on this.
|
dabura667
force-pushed
the
bitcoincash
branch
3 times, most recently
from
5ef1dbc to
e39f820
Compare
dabura667
force-pushed
the
bitcoincash
branch
from
6d6d332 to
0d93aa9
Compare
dabura667
pushed a commit
that referenced
this pull request
Apr 19, 2020
sync with OutCast3k/coinbin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had an address with 200+ UTXOs, and it kept failing to sign.. I then saw it tried to make 1800+ ajax calls to the same url, constantly fetching the UTXOs for each input. These checks speed it up somewhat.