Build updates for API 34 + Flutter 3.24 #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please merge this, the package literally breaks compilation of the entire app because of this issue. |
|
@daadu : Please consider this Pull Request or make a similar one that solves this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These 3 commits were necessary for me to get the plugin to be included in a Release build targeting API 34 and Flutter 3.24. I saw no errors in a debug build but didn't thoroughly test functionality that depends on this plugin before finding that the apk build failed in release mode. I haven't tested any older API or Flutter versions.
I'm not 100% sure every change was needed in the end but it is working for me so I thought might be useful for others and if there are no problems with backwards compatibility, could potentially be merged in for a future release.
If there are any backwards compatibility problems you're bothered about, feel free to close the PR or ask for changes.
I've not migrated the plugin to the new Flutter Gradle declarative plugins block but have done that for other plugins recently so let me know if you'd like me to work on a follow-up PR with that change later.
Edit: In case it helps others find this, the build error that led me down this path was along the lines of "AAPT: error: resource android:attr/lStar not found."