SystemCleaner: Improve custom filter behavior and support creation via StorageAnalyzer #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oving and re-adding
d4rken
added
enhancement
Might be a bit more dangerous but it's super frustrating. (and if we create one via analyzer, then the user needs to navigate and extra round-trip just to enable it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the
BaseSieveclass used by the SystemCleaner to support more complex filter config arguments.In turn we can now create nice custom filters via StorageAnalyzer. Before this refactoring it was problematic to create a custom filter that deletes specific files, and a whole directory without accidentally including other directories that have the first directories name as prefix.
i.e. we want a FULL match of
path/fileAand also matchpath/folderA/without matchingpath/folderAB, but the only tools we had waspathContains.This change now gives us
SegmentCriteriaandNameCriteriawhich each support different modes likeSTART, END, CONTAIN, EQUALso when creating custom filters we can create aSegmentCriteriumwithMode.Equalfor matching a specific path, while usingMode.Startto match a folder and all that is in it.Due to the change in format, the previous custom filters are deleted. I opted for not creating migration code as this is a BETA and migration code is not great to lug around after beta.