-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Material You design changes and widgets update #209
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies all major elements of the UI for phones to use Material3 elements, including the toolbar. Signed-off-by: Ricky Cheung <[email protected]>
Signed-off-by: Ricky Cheung <[email protected]>
Going by 2f9185e, it appears the label is preferred to be at the bottom Signed-off-by: Ricky Cheung <[email protected]>
* Wide variant activates when the widget is larger than 3 columns in length Signed-off-by: Ricky Cheung <[email protected]>
Signed-off-by: Ricky Cheung <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Ricky Cheung <[email protected]>
d4rken
reviewed
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good ❤️
Can you take some screenshots in light-mode?
app/src/main/java/eu/darken/capod/main/ui/widget/WidgetProvider.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Ricky Cheung <[email protected]>
Signed-off-by: Ricky Cheung <[email protected]>
Signed-off-by: Ricky Cheung <[email protected]>
Signed-off-by: Ricky Cheung <[email protected]>
* Also move the case details to the centre and separate the text a little Signed-off-by: Ricky Cheung <[email protected]>
d4rken
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have took some time to modify the app so that it no longer uses MaterialComponents styling. However, some more changes may be needed. Please edit as you see fit.
For the widgets change, I've added a wide variant of the dual pods widget, which gets activated when the widget is larger than 3 columns.