Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material You design changes and widgets update #209

Merged
merged 11 commits into from
Jun 26, 2024
Merged

Conversation

rcky844
Copy link

@rcky844 rcky844 commented Jun 26, 2024

I have took some time to modify the app so that it no longer uses MaterialComponents styling. However, some more changes may be needed. Please edit as you see fit.

For the widgets change, I've added a wide variant of the dual pods widget, which gets activated when the widget is larger than 3 columns.

Ricky Cheung added 5 commits June 26, 2024 12:13
This commit modifies all major elements of the UI for phones to use Material3 elements, including the toolbar.

Signed-off-by: Ricky Cheung <[email protected]>
Signed-off-by: Ricky Cheung <[email protected]>
Going by 2f9185e, it appears the label is preferred to be at the bottom

Signed-off-by: Ricky Cheung <[email protected]>
* Wide variant activates when the widget is larger than 3 columns in length

Signed-off-by: Ricky Cheung <[email protected]>
@rcky844
Copy link
Author

rcky844 commented Jun 26, 2024

Screenshots for the changes

@rcky844

This comment was marked as outdated.

Copy link
Member

@d4rken d4rken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good ❤️

Can you take some screenshots in light-mode?

@rcky844
Copy link
Author

rcky844 commented Jun 26, 2024

Thanks! Looks good ❤️

Can you take some screenshots in light-mode?

Here you go:


Ricky Cheung added 3 commits June 26, 2024 17:19
@rcky844
Copy link
Author

rcky844 commented Jun 26, 2024

@d4rken

Slight design change:
Would you prefer if the wide weights looked like this?

Ricky Cheung added 2 commits June 26, 2024 17:34
Signed-off-by: Ricky Cheung <[email protected]>
* Also move the case details to the centre and separate the text a little

Signed-off-by: Ricky Cheung <[email protected]>
@rcky844
Copy link
Author

rcky844 commented Jun 26, 2024

Copy link
Member

@d4rken d4rken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@d4rken d4rken merged commit bbfb735 into d4rken-org:main Jun 26, 2024
7 checks passed
@d4rken d4rken added the enhancement Add a new feature of improve an existing feature label Jun 27, 2024
d4rken added a commit that referenced this pull request Jul 12, 2024
d4rken added a commit that referenced this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Add a new feature of improve an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants