-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Data and Data Type artifact #190
base: develop
Are you sure you want to change the base?
Conversation
@@ -20817,10 +20930,18 @@ User web session data is collected over a period of time to create a user behavi | |||
|
|||
:WindowsRegistryValue a owl:Class ; | |||
rdfs:label "Windows Registry Value" ; | |||
rdfs:subClassOf :SystemConfigurationDatabaseRecord, | |||
rdfs:subClassOf :ComplexDataStructure, | |||
:Structure, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@netfl0 I think this line is the only line that looks a little strange to me, Trying to convey that a Windows Registry is a type of the Structure Data Type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
subclassof ComplexDataStructure is unnecessary since :Structure is a type of ComplexDataStructure.
Agree?
@netfl0 Are there any other additions that need to be made here? |
Need to merge develop into this branch, and see my comment on redundant subclass. |
@netfl0 where is your redundant subclass method? |
@@ -20817,10 +20930,18 @@ User web session data is collected over a period of time to create a user behavi | |||
|
|||
:WindowsRegistryValue a owl:Class ; | |||
rdfs:label "Windows Registry Value" ; | |||
rdfs:subClassOf :SystemConfigurationDatabaseRecord, | |||
rdfs:subClassOf :ComplexDataStructure, | |||
:Structure, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
subclassof ComplexDataStructure is unnecessary since :Structure is a type of ComplexDataStructure.
Agree?
my review was in draft, apologies: |
Addresses #174