Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Data and Data Type artifact #190

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

ryantxu1
Copy link
Collaborator

Addresses #174

@@ -20817,10 +20930,18 @@ User web session data is collected over a period of time to create a user behavi

:WindowsRegistryValue a owl:Class ;
rdfs:label "Windows Registry Value" ;
rdfs:subClassOf :SystemConfigurationDatabaseRecord,
rdfs:subClassOf :ComplexDataStructure,
:Structure,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@netfl0 I think this line is the only line that looks a little strange to me, Trying to convey that a Windows Registry is a type of the Structure Data Type.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subclassof ComplexDataStructure is unnecessary since :Structure is a type of ComplexDataStructure.

Agree?

@ryantxu1
Copy link
Collaborator Author

@netfl0 Are there any other additions that need to be made here?

@netfl0
Copy link
Contributor

netfl0 commented Jul 12, 2023

Need to merge develop into this branch, and see my comment on redundant subclass.

@ryantxu1
Copy link
Collaborator Author

@netfl0 where is your redundant subclass method?

@@ -20817,10 +20930,18 @@ User web session data is collected over a period of time to create a user behavi

:WindowsRegistryValue a owl:Class ;
rdfs:label "Windows Registry Value" ;
rdfs:subClassOf :SystemConfigurationDatabaseRecord,
rdfs:subClassOf :ComplexDataStructure,
:Structure,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subclassof ComplexDataStructure is unnecessary since :Structure is a type of ComplexDataStructure.

Agree?

@netfl0
Copy link
Contributor

netfl0 commented Aug 22, 2024

@netfl0 where is your redundant subclass method?

my review was in draft, apologies:

#190 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants