CMake build fixes and Actions workflow #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows CMakeLists.txt modifications that did not work
Build using CMake, fetches latest ESP8266 Core to build against
d-a-v
approved these changes
Jul 10, 2022
|
:oops: |
Merged
mcspr
added a commit
that referenced
this pull request
Jul 13, 2022
amends #59 - cmake defaults to empty variables. if repo is some place else, git simply errors out and the resulting description var will also be empty (like it is currently happening in actions .yml) - toolchain .cmake is 'sourced' multiple times when running cmake for the first time. Instead of using list var, just use the built-in global flag setter (which also takes care of flag unique-ness, as well as caching) - -std=... flags were missing - files with platform-specific things are suffixed with *-esp8266.cmake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #55 by moving build flags into main and lwip builder .cmake files
also testing this using github actions running on prs and main branch pushes