-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update supported CEF version, and a bunch of other changes #22
Open
em-tg
wants to merge
35
commits into
cztomczak:master
Choose a base branch
from
em-tg:emy
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update to support the latest CEF - fix make the Makefile responsible for extracting CEF - drop support for gtk2 - get rid of a bunch of workarounds for no-longer-applicable bugs - fix reference counting to prevent crashing on exit
also: - stop git from doing newline substitution
em-tg
changed the title
Update CEF, and a bunch of other changes
Update supported CEF version, and a bunch of other changes
Apr 1, 2024
The GPU process crashes on windows for some reason when we compile with MSVC but not when we compile with MinGW (maybe stdlib-related?). Happens in libcef in a call to CreateWindowsOnThread, which is being used by chrome for something directx-related. The debugger says CreateWindowEx returns NULL but that GetLastError() is ERROR_SUCCESS, suggesting something wrong with the WndProc. https://chromium.googlesource.com/chromium/src/+/refs/heads/main/ui/gl/child_window_win.cc#108 chromiumembedded/cef#3765
cefcapi appears to be affected by chromiumembedded/cef#3765 |
Should be good to go, now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried using this repo as a jumping-off point for a project a few years ago, and am thankful it exists. It was a little difficult to get started with it, though, since it didn't work with the latest version of CEF, and had a number of other issues. Since it doesn't seem to have received any updates since then, I thought I'd submit a PR so others don't have to struggle as much as I did.
This PR updates to the latest CEF version, fixes a number of issues, implements "true" reference counting, and "cleans" the C a bit. Some of the changes are just random things I thought would be a good idea, so feel free to edit and strip out the bits you don't want (or tell me to do so).
List of changes:
cef_client.h
andcef_app.h
, since I didn't want to go through addingrelease
calls all over the place in functions that weren't being usedcef_initialize
andcef_browser_host_create_browser
client_handler_t
and usecontainer_of
to extract it from cef_clientsizeof val
tosizeof(type)
cef_load_handler
to demonstrate reference countingcef*.tar.bz2
using the build scripts requires 7zip. Windows hastar
but it can't handle.bz2
:P