Merge rust-lang#1355

1355: Fix badges for crates with prerelease versions r=sgrif Dashes are used to separate sections, and need to be escaped. I had thought that `crate.max_version` never included prereleases, but I was wrong.
czotomo · Apr 14, 2018 · 783d0f2 · 783d0f2
2 parents 78b408b + e36456a
commit 783d0f2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/app/components/crate-badge.js b/app/components/crate-badge.js
@@ -6,6 +6,10 @@ export default Component.extend({
 
     tagName: 'span',
 
+    version: computed('crate.max_version', function() {
+        return this.get('crate.max_version').replace('-', '--');
+    }),
+
     color: computed('crate.max_version', function() {
         if (this.get('crate.max_version')[0] == '0') {
             return 'orange';

diff --git a/app/templates/components/crate-badge.hbs b/app/templates/components/crate-badge.hbs
@@ -1,5 +1,5 @@
 <img
-    src="https://img.shields.io/badge/crates.io-v{{ crate.max_version }}-{{ color }}.svg?longCache=true"
+    src="https://img.shields.io/badge/crates.io-v{{ version }}-{{ color }}.svg?longCache=true"
     alt="{{ crate.max_version }}"
     title="{{ crate.name }}’s current version badge"
     data-test-version-badge>