Prometheus Operator support #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, I started using this project recently so I decided to contribute support for the Prometheus Operator. This change only affects the Helm chart, but allows seamless integration for people using Kubernetes and the Prometheus Operator.
Setting
serviceMonitor.enabled: truecreates a serviceMonitor resource which makes Prometheus start scraping the exporter.Setting
prometheusRules.enabled: trueadds some basic Prometheus alerting rules which alert on high latency or high packet loss.This is tested & working on my Prometheus Operator stack.
Do you need me to bump the chart version before you merge?