-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of cropping.py #229
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in our meeting with @talonchandler. I think the convenience functions like get_positions
andget_channel_indices
would be great to have inside iohub.
@ziw-liu what would be a good place to have these (iohub.ngff?)
chunks = (1, 1, 1, shape[3], shape[4]) | ||
|
||
# position keys | ||
position_keys = [self.validate_position_key(path) for path, _ in positions] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could run everything in a single for loop
Can you explain why is |
Feel free to ignore this comment because no one asked for my review. Since the unified API was merged, I think it would be nice for this function to take a |
The catch here is that OME-Zarr UAPI is still pending... |
Sample script to index into either time, channels, z, y, and x into an existing ome-zarr store and create a new ome-zarr store with crops. Code is currently structured as a class with some helper methods but can be re-factored as some utils methods that are used in the script directly (without the class structure).