fix bug determining number of rows and cols

czbiohub-sf · Mar 8, 2024 · 9e8fa4d · 9e8fa4d
1 parent 3ab89ba
commit 9e8fa4d
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/iohub/convert.py b/iohub/convert.py
@@ -180,8 +180,8 @@ def _make_default_grid(self):
             )
 
     def _get_position_coords(self):
-        row_max = 0
-        col_max = 0
+        rows = set()
+        cols = set()
         coords_list = []
 
         # TODO: read rows, cols directly from XY corods
@@ -196,16 +196,14 @@ def _get_position_coords(self):
                 )
             coords_list.append(stage_pos)
             try:
-                row = pos["GridRow"]
-                col = pos["GridCol"]
+                rows.add(pos["GridRow"])
+                cols.add(pos["GridCol"])
             except KeyError:
                 raise ValueError(
                     f"Grid indices not available for position {idx}"
                 )
-            row_max = row if row > row_max else row_max
-            col_max = col if col > col_max else col_max
 
-        return coords_list, row_max + 1, col_max + 1
+        return coords_list, len(rows), len(cols)
 
     def _get_pos_names(self):
         """Append a list of pos names in ascending order