WIP: update GitHub workflow to use cyd #5204
Conversation
Sphinx warns if the width of the underline falls short of the header text!
rjbs
force-pushed
the
test-with-cyd
branch
9 times, most recently
from
302f5fc to
d5fc15a
Compare
.github/workflows/main.yml
Outdated
| working-directory: cassandane | ||
| run: setpriv --reuid=cyrus --regid=mail --clear-groups --inh-caps='-chown,-dac_override,-dac_read_search,-fowner,-fsetid,-kill,-setgid,-setuid,-setpcap,-linux_immutable,-net_bind_service,-net_broadcast,-net_admin,-net_raw,-ipc_lock,-ipc_owner,-sys_module,-sys_rawio,-sys_chroot,-sys_ptrace,-sys_pacct,-sys_admin,-sys_boot,-sys_nice,-sys_resource,-sys_time,-sys_tty_config,-mknod,-lease,-audit_write,-audit_control,-setfcap,-mac_override,-mac_admin,-syslog,-wake_alarm,-block_suspend,-audit_read,-cap_38,-cap_39,-cap_40' ./testrunner.pl --slow -f prettier -j 8 !Test::Core | ||
| run: cyd test |
There was a problem hiding this comment.
CI for this one is failing on the Test::Core tests, which we used to skip in CI (!Test::Core at the end of the run command), but with this change I guess they're no longer skipped.
These tests prove that Cassandane can detect when Cyrus crashed -- which means, if these tests succeed, and everything else also succeeded, then nothing crashed. When these tests fail (or are skipped), that means Cassandane can't detect Cyrus crashes, and tests that result in Cyrus crashes might accidentally report success if the test itself didn't notice the crash.
So it would be good to not skip them, but I never figured out how to get them working in CI. On a normal system, you need to configure a few things to get crashed processes to dump core. On CI, between all the layers of docker and stuff, I don't know what's configured or where to change it.
There was a problem hiding this comment.
Interesting. They must(?) be passing in Docker for cyd/dar to work, so it'll be something more constrained on GitHub Actions.
No description provided.