Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cyr_cd.sh: change to POSIX sh style #4691

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

obache
Copy link
Contributor

@obache obache commented Oct 17, 2023

function keyword is not required to declare functions.
Additionally, prevent to overwrite global scope variables.

`function` keyword is not required to declare functions.
Additionally, prevent to overwrite global scope variables.

Signed-off-by: OBATA Akio <[email protected]>
@obache
Copy link
Contributor Author

obache commented Oct 17, 2023

related to #4293

@elliefm elliefm requested a review from ksmurchison October 19, 2023 23:35
Copy link
Contributor

@ksmurchison ksmurchison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a shell programming expert, but LGTM

@ksmurchison ksmurchison merged commit 5ecc318 into cyrusimap:master Oct 20, 2023
@obache obache deleted the cyr_cd-bash-to-sh branch October 25, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants