-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add xzrealloc #4682
add xzrealloc #4682
Conversation
52112d5
to
138f7ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just found one nit. And this PR again higlights how much code still uses int
at places where we really want to use size_t
😔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to remove the stray memset() as pointed out by rsto. Once done, I approve without a re-review
and the misleading comment describing it
138f7ec
to
f4d16f4
Compare
requested changes applied; re-review not required
Adds an
xzrealloc()
function that's likexrealloc()
but also zeroes out the newly allocated bytes if the allocation grew in size. n.b. It needs one more argument than regularxrealloc()
, so it's not a drop-in replacement.