Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENG-14011: Add vault_integration_id field to cyral_sidecar resource in terraform provider #565

Merged
merged 3 commits into from
Sep 6, 2024
Merged

ENG-14011: Add vault_integration_id field to cyral_sidecar resource in terraform provider #565

merged 3 commits into from
Sep 6, 2024

Conversation

VictorGFM
Copy link
Contributor

@VictorGFM VictorGFM commented Sep 6, 2024 •
edited by jira bot
Loading

Description of the change

ENG-14011: Add vault_integration_id field to cyral_sidecar resource in terraform provider

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Jira issue referenced in commit message and/or PR title

Testing

Running acceptance tests and testing the sidecar resource using local changes.

@VictorGFM VictorGFM requested a review from wcmjunior September 6, 2024 03:24
@VictorGFM VictorGFM requested a review from wcmjunior September 6, 2024 20:06
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 6, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

wcmjunior
wcmjunior approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@wcmjunior wcmjunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @VictorGFM !

@wcmjunior wcmjunior merged commit 9789a2d into main Sep 6, 2024
2 checks passed
@wcmjunior wcmjunior deleted the ENG-14011 branch September 6, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wcmjunior wcmjunior wcmjunior approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VictorGFM @wcmjunior