Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-14270: redshift iam #559

Merged
merged 5 commits into from
Aug 11, 2024
Merged

ENG-14270: redshift iam #559

merged 5 commits into from
Aug 11, 2024

Conversation

ricardorey10
Copy link
Contributor

Description of the change

We recently added the capability for Redshift repos to use AWS IAM as the Authentication method between the sidecar and the DB. In order to do this, we added a few fields to the repo and the userAccount objects, so this PR teaches Terraform about them.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Jira issue referenced in commit message and/or PR title

Testing

Added a couple new unit tests and they passed.

@ricardorey10 ricardorey10 requested a review from wcmjunior August 8, 2024 21:29
Copy link

sonarqubecloud bot commented Aug 9, 2024

Copy link
Contributor

@wcmjunior wcmjunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! TYVM!

@wcmjunior wcmjunior merged commit 226745c into main Aug 11, 2024
2 checks passed
@wcmjunior wcmjunior deleted the feature/ENG-14270/redshift_iam branch August 11, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants