Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve examples for resources policy and policy_rules #545

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

wcmjunior
Copy link
Contributor

@wcmjunior wcmjunior commented Jun 6, 2024

Description of the change

Improve examples for resources cyral_policy and cyral_policy_rules to show a rego policy use case. The current examples just show all fields of the resources and don't show a tangible use case. The goal for this PR is add some meaningful policy that can be read and understood by users.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Jira issue referenced in commit message and/or PR title

Testing

NA

@wcmjunior wcmjunior requested a review from VictorGFM June 6, 2024 06:52
Copy link

sonarqubecloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@VictorGFM VictorGFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wcmjunior wcmjunior merged commit 1cfb4d8 into main Jun 6, 2024
2 checks passed
@wcmjunior wcmjunior deleted the docs/policy branch June 6, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants