Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-14083: Add Azure Key Vault user account auth scheme #542

Merged
merged 5 commits into from
Jun 5, 2024

Conversation

ccampo133
Copy link
Contributor

@ccampo133 ccampo133 commented Jun 4, 2024

Description of the change

As title.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Jira issue referenced in commit message and/or PR title

Testing

GOROOT=/usr/local/opt/go/libexec #gosetup
GOPATH=/Users/ccampo/go #gosetup
/usr/local/opt/go/libexec/bin/go test -c -o /Users/ccampo/Library/Caches/JetBrains/IntelliJIdea2024.1/tmp/GoLand/___1resource_test_go.test github.com/cyralinc/terraform-provider-cyral/cyral/internal/repository/useraccount #gosetup
/usr/local/opt/go/libexec/bin/go tool test2json -t /Users/ccampo/Library/Caches/JetBrains/IntelliJIdea2024.1/tmp/GoLand/___1resource_test_go.test -test.v -test.paniconexit0 -test.run ^\QTestAccRepositoryUserAccountResource\E$
=== RUN   TestAccRepositoryUserAccountResource
=== PAUSE TestAccRepositoryUserAccountResource
=== CONT  TestAccRepositoryUserAccountResource
--- PASS: TestAccRepositoryUserAccountResource (31.69s)
PASS

Process finished with the exit code 0
Screenshot 2024-06-05 at 12 59 51 PM

@ccampo133 ccampo133 changed the title Add Azure Key Vault user account auth scheme ENG-14083: Add Azure Key Vault user account auth scheme Jun 4, 2024
@ccampo133 ccampo133 requested a review from wcmjunior June 4, 2024 20:51
Copy link
Contributor

@wcmjunior wcmjunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update docs and add some tests for the new feature.

@ccampo133 ccampo133 requested a review from wcmjunior June 5, 2024 16:21
Copy link

sonarqubecloud bot commented Jun 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
45.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@wcmjunior wcmjunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@wcmjunior wcmjunior merged commit e8d106c into main Jun 5, 2024
2 checks passed
@wcmjunior wcmjunior deleted the azure_key_vault branch June 5, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants