Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-13977: Add deprecation message in existing ELK Terraform #540

Merged
merged 2 commits into from
May 31, 2024

Conversation

gabfelp
Copy link
Contributor

@gabfelp gabfelp commented May 30, 2024

Description of the change

We're going to deprecate ELK in the next major due to inconsistencies/confusion between versions v7/v8, so we need to direct users to migrate to custom logging integration instead.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Jira issue referenced in commit message and/or PR title

Testing

Description of testing

@gabfelp gabfelp requested review from VictorGFM and wcmjunior May 31, 2024 21:06
@gabfelp gabfelp marked this pull request as ready for review May 31, 2024 21:06
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Comment on lines +25 to +29
name = "my-splunk-integration"
splunk {
hostname = "http://splunk.com"
hec_port = "8088"
access_token = "XXXXXXXXXXX"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated example to use Splunk instead

@wcmjunior wcmjunior merged commit 3262b93 into main May 31, 2024
2 checks passed
@wcmjunior wcmjunior deleted the ENG-13977 branch May 31, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants