Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENG-12954, ENG-12955: Add datasource and resource fot token settings #479

Merged
merged 7 commits into from
Nov 29, 2023
Merged

ENG-12954, ENG-12955: Add datasource and resource fot token settings #479

merged 7 commits into from
Nov 29, 2023

Conversation

VictorGFM
Copy link
Contributor

@VictorGFM VictorGFM commented Nov 18, 2023 •
edited
Loading

Description of the change

ENG-12954: Create a terraform resource for configuring access token settings
ENG-12955: Create a terraform data source for retrieving access token settings

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Jira issue referenced in commit message and/or PR title

Testing

Automated tests and manual E2E tests for the new data source and resource. See results below:

go test github.com/cyralinc/terraform-provider-cyral/... -v -race -timeout 20m
?   	github.com/cyralinc/terraform-provider-cyral	[no test files]
?   	github.com/cyralinc/terraform-provider-cyral/cyral/core	[no test files]
=== RUN   TestNewClient_WhenTLSSkipVerifyIsEnabled_ThenInsecureSkipVerifyIsTrue
2023/11/28 20:09:56 [DEBUG] Init client.New
2023/11/28 20:09:56 [DEBUG] TokenSource: &{0xc00000cf18 {0 0} <nil> 0}
2023/11/28 20:09:56 [DEBUG] End client.New
--- PASS: TestNewClient_WhenTLSSkipVerifyIsEnabled_ThenInsecureSkipVerifyIsTrue (0.00s)
=== RUN   TestNewClient_WhenTLSSkipVerifyIsDisabled_ThenInsecureSkipVerifyIsFalse
2023/11/28 20:09:56 [DEBUG] Init client.New
2023/11/28 20:09:56 [DEBUG] TokenSource: &{0xc00000cf60 {0 0} <nil> 0}
2023/11/28 20:09:56 [DEBUG] End client.New
--- PASS: TestNewClient_WhenTLSSkipVerifyIsDisabled_ThenInsecureSkipVerifyIsFalse (0.00s)
=== RUN   TestNewClient_WhenClientIDIsEmpty_ThenThrowError
2023/11/28 20:09:56 [DEBUG] Init client.New
--- PASS: TestNewClient_WhenClientIDIsEmpty_ThenThrowError (0.00s)
=== RUN   TestNewClient_WhenClientSecretIsEmpty_ThenThrowError
2023/11/28 20:09:56 [DEBUG] Init client.New
--- PASS: TestNewClient_WhenClientSecretIsEmpty_ThenThrowError (0.00s)
=== RUN   TestNewClient_WhenControlPlaneIsEmpty_ThenThrowError
2023/11/28 20:09:56 [DEBUG] Init client.New
--- PASS: TestNewClient_WhenControlPlaneIsEmpty_ThenThrowError (0.00s)
PASS
ok  	github.com/cyralinc/terraform-provider-cyral/cyral/client	(cached)
?   	github.com/cyralinc/terraform-provider-cyral/cyral/internal/datalabel/classificationrule	[no test files]
?   	github.com/cyralinc/terraform-provider-cyral/cyral/internal/integration/confextension	[no test files]
=== RUN   TestAccDatalabelDataSource
=== PAUSE TestAccDatalabelDataSource
=== RUN   TestAccDatalabelResource
=== PAUSE TestAccDatalabelResource
=== CONT  TestAccDatalabelResource
=== CONT  TestAccDatalabelDataSource
--- PASS: TestAccDatalabelResource (12.54s)
--- PASS: TestAccDatalabelDataSource (25.79s)
PASS
ok  	github.com/cyralinc/terraform-provider-cyral/cyral/internal/datalabel	26.987s
=== RUN   TestAccSidecarCftTemplateDataSource
=== PAUSE TestAccSidecarCftTemplateDataSource
=== RUN   TestAccSidecarInstanceIDsDataSource
=== PAUSE TestAccSidecarInstanceIDsDataSource
=== RUN   TestIntegrationsData_GetValue_Default
--- PASS: TestIntegrationsData_GetValue_Default (0.00s)
=== RUN   TestIntegrationsData_GetValue_Splunk
--- PASS: TestIntegrationsData_GetValue_Splunk (0.00s)
=== RUN   TestAccDatadogIntegrationResource
=== PAUSE TestAccDatadogIntegrationResource
=== RUN   TestAccELKIntegrationResource
=== PAUSE TestAccELKIntegrationResource
=== RUN   TestAccIdPIntegrationResource
=== PAUSE TestAccIdPIntegrationResource
=== RUN   TestAccLogstashIntegrationResource
=== PAUSE TestAccLogstashIntegrationResource
=== RUN   TestAccLookerIntegrationResource
=== PAUSE TestAccLookerIntegrationResource
=== RUN   TestAccSplunkIntegrationResource
=== PAUSE TestAccSplunkIntegrationResource
=== RUN   TestAccSumoLogicIntegrationResource
=== PAUSE TestAccSumoLogicIntegrationResource
=== CONT  TestAccELKIntegrationResource
=== CONT  TestAccIdPIntegrationResource
=== CONT  TestAccLookerIntegrationResource
=== CONT  TestAccSplunkIntegrationResource
=== CONT  TestAccLogstashIntegrationResource
=== CONT  TestAccDatadogIntegrationResource
=== CONT  TestAccSidecarInstanceIDsDataSource
=== CONT  TestAccSidecarCftTemplateDataSource
--- PASS: TestAccELKIntegrationResource (13.30s)
=== CONT  TestAccSumoLogicIntegrationResource
--- PASS: TestAccLookerIntegrationResource (14.16s)
--- PASS: TestAccDatadogIntegrationResource (14.47s)
--- PASS: TestAccSplunkIntegrationResource (16.27s)
--- PASS: TestAccSidecarInstanceIDsDataSource (16.94s)
--- PASS: TestAccLogstashIntegrationResource (22.07s)
--- PASS: TestAccSumoLogicIntegrationResource (8.77s)
--- PASS: TestAccSidecarCftTemplateDataSource (23.11s)
--- PASS: TestAccIdPIntegrationResource (54.64s)
PASS
ok  	github.com/cyralinc/terraform-provider-cyral/cyral/internal/deprecated	55.267s
=== RUN   TestIntegrationAWSIAMAuthN
=== PAUSE TestIntegrationAWSIAMAuthN
=== CONT  TestIntegrationAWSIAMAuthN
--- PASS: TestIntegrationAWSIAMAuthN (22.42s)
PASS
ok  	github.com/cyralinc/terraform-provider-cyral/cyral/internal/integration/awsiam	24.268s
=== RUN   TestAccDuoMFAIntegrationResource
=== PAUSE TestAccDuoMFAIntegrationResource
=== CONT  TestAccDuoMFAIntegrationResource
--- PASS: TestAccDuoMFAIntegrationResource (11.42s)
PASS
ok  	github.com/cyralinc/terraform-provider-cyral/cyral/internal/integration/confextension/mfaduo	12.312s
=== RUN   TestAccPagerDutyIntegrationResource
=== PAUSE TestAccPagerDutyIntegrationResource
=== CONT  TestAccPagerDutyIntegrationResource
--- PASS: TestAccPagerDutyIntegrationResource (11.87s)
PASS
ok  	github.com/cyralinc/terraform-provider-cyral/cyral/internal/integration/confextension/pagerduty	14.321s
=== RUN   TestAccHCVaultIntegrationResource
=== PAUSE TestAccHCVaultIntegrationResource
=== CONT  TestAccHCVaultIntegrationResource
--- PASS: TestAccHCVaultIntegrationResource (11.62s)
PASS
ok  	github.com/cyralinc/terraform-provider-cyral/cyral/internal/integration/hcvault	13.193s
=== RUN   TestAccIntegrationIdPSAMLDataSource
=== PAUSE TestAccIntegrationIdPSAMLDataSource
=== RUN   TestAccIntegrationIdPSAMLDraftResource
=== PAUSE TestAccIntegrationIdPSAMLDraftResource
=== RUN   TestAccIntegrationIdPSAMLResource
=== PAUSE TestAccIntegrationIdPSAMLResource
=== CONT  TestAccIntegrationIdPSAMLResource
=== CONT  TestAccIntegrationIdPSAMLDraftResource
=== CONT  TestAccIntegrationIdPSAMLDataSource
--- PASS: TestAccIntegrationIdPSAMLDraftResource (16.50s)
--- PASS: TestAccIntegrationIdPSAMLDataSource (28.56s)
--- PASS: TestAccIntegrationIdPSAMLResource (33.12s)
PASS
ok  	github.com/cyralinc/terraform-provider-cyral/cyral/internal/integration/idpsaml	35.092s
=== RUN   TestAccLoggingIntegrationDataSource
=== PAUSE TestAccLoggingIntegrationDataSource
=== RUN   TestAccLogsIntegrationResourceCloudWatch
=== PAUSE TestAccLogsIntegrationResourceCloudWatch
=== RUN   TestAccLogsIntegrationResourceDataDog
=== PAUSE TestAccLogsIntegrationResourceDataDog
=== RUN   TestAccLogsIntegrationResourceElk
=== PAUSE TestAccLogsIntegrationResourceElk
=== RUN   TestAccLogsIntegrationResourceElkEmptyEsCredentials
=== PAUSE TestAccLogsIntegrationResourceElkEmptyEsCredentials
=== RUN   TestAccLogsIntegrationResourceSplunk
=== PAUSE TestAccLogsIntegrationResourceSplunk
=== RUN   TestAccLogsIntegrationResourceSumologic
=== PAUSE TestAccLogsIntegrationResourceSumologic
=== RUN   TestAccLogsIntegrationResourceFluentbit
=== PAUSE TestAccLogsIntegrationResourceFluentbit
=== CONT  TestAccLogsIntegrationResourceDataDog
=== CONT  TestAccLogsIntegrationResourceElkEmptyEsCredentials
=== CONT  TestAccLogsIntegrationResourceSplunk
=== CONT  TestAccLogsIntegrationResourceSumologic
=== CONT  TestAccLogsIntegrationResourceCloudWatch
=== CONT  TestAccLoggingIntegrationDataSource
=== CONT  TestAccLogsIntegrationResourceElk
=== CONT  TestAccLogsIntegrationResourceFluentbit
--- PASS: TestAccLogsIntegrationResourceDataDog (11.97s)
--- PASS: TestAccLogsIntegrationResourceSplunk (13.97s)
--- PASS: TestAccLogsIntegrationResourceFluentbit (14.19s)
--- PASS: TestAccLogsIntegrationResourceElk (14.21s)
--- PASS: TestAccLogsIntegrationResourceSumologic (14.29s)
--- PASS: TestAccLogsIntegrationResourceElkEmptyEsCredentials (14.86s)
--- PASS: TestAccLogsIntegrationResourceCloudWatch (14.90s)
--- PASS: TestAccLoggingIntegrationDataSource (16.33s)
PASS
ok  	github.com/cyralinc/terraform-provider-cyral/cyral/internal/integration/logging	18.524s
=== RUN   TestAccSlackAlertsIntegrationResource
=== PAUSE TestAccSlackAlertsIntegrationResource
=== CONT  TestAccSlackAlertsIntegrationResource
--- PASS: TestAccSlackAlertsIntegrationResource (7.35s)
PASS
ok  	github.com/cyralinc/terraform-provider-cyral/cyral/internal/integration/slack	7.698s
=== RUN   TestAccMsTeamsIntegrationResource
=== PAUSE TestAccMsTeamsIntegrationResource
=== CONT  TestAccMsTeamsIntegrationResource
--- PASS: TestAccMsTeamsIntegrationResource (7.17s)
PASS
ok  	github.com/cyralinc/terraform-provider-cyral/cyral/internal/integration/teams	7.526s
=== RUN   TestAccPermissionDataSource
=== PAUSE TestAccPermissionDataSource
=== CONT  TestAccPermissionDataSource
--- PASS: TestAccPermissionDataSource (6.53s)
PASS
ok  	github.com/cyralinc/terraform-provider-cyral/cyral/internal/permission	7.145s
=== RUN   TestAccPolicyResource
=== PAUSE TestAccPolicyResource
=== CONT  TestAccPolicyResource
--- PASS: TestAccPolicyResource (9.06s)
PASS
ok  	github.com/cyralinc/terraform-provider-cyral/cyral/internal/policy	9.400s
=== RUN   TestAccPolicyRuleResource
=== PAUSE TestAccPolicyRuleResource
=== RUN   TestPolicyRuleResourceUpgradeV0
--- PASS: TestPolicyRuleResourceUpgradeV0 (0.00s)
=== CONT  TestAccPolicyRuleResource
--- PASS: TestAccPolicyRuleResource (19.26s)
PASS
ok  	github.com/cyralinc/terraform-provider-cyral/cyral/internal/policy/rule	19.613s
=== RUN   TestAccRegoPolicyInstanceResource
=== PAUSE TestAccRegoPolicyInstanceResource
=== CONT  TestAccRegoPolicyInstanceResource
--- PASS: TestAccRegoPolicyInstanceResource (8.58s)
PASS
ok  	github.com/cyralinc/terraform-provider-cyral/cyral/internal/regopolicy	9.245s
=== RUN   TestAccRepositoryDataSource
=== PAUSE TestAccRepositoryDataSource
=== RUN   TestAccRepositoryResource
=== PAUSE TestAccRepositoryResource
=== CONT  TestAccRepositoryResource
=== CONT  TestAccRepositoryDataSource
--- PASS: TestAccRepositoryDataSource (15.63s)
--- PASS: TestAccRepositoryResource (20.75s)
PASS
ok  	github.com/cyralinc/terraform-provider-cyral/cyral/internal/repository	21.081s
=== RUN   TestAccRepositoryAccessGatewayResource
=== PAUSE TestAccRepositoryAccessGatewayResource
=== CONT  TestAccRepositoryAccessGatewayResource
--- PASS: TestAccRepositoryAccessGatewayResource (18.88s)
PASS
ok  	github.com/cyralinc/terraform-provider-cyral/cyral/internal/repository/accessgateway	19.270s
=== RUN   TestAccRepositoryAccessRulesResource
=== PAUSE TestAccRepositoryAccessRulesResource
=== CONT  TestAccRepositoryAccessRulesResource
--- PASS: TestAccRepositoryAccessRulesResource (15.61s)
PASS
ok  	github.com/cyralinc/terraform-provider-cyral/cyral/internal/repository/accessrules	15.936s
=== RUN   TestAccRepositoryBindingResource
=== PAUSE TestAccRepositoryBindingResource
=== CONT  TestAccRepositoryBindingResource
--- PASS: TestAccRepositoryBindingResource (10.24s)
PASS
ok  	github.com/cyralinc/terraform-provider-cyral/cyral/internal/repository/binding	10.564s
=== RUN   TestAccRepositoryConfAnalysisResource
=== PAUSE TestAccRepositoryConfAnalysisResource
=== RUN   TestRepositoryConfAnalysisResourceUpgradeV0
--- PASS: TestRepositoryConfAnalysisResourceUpgradeV0 (0.00s)
=== CONT  TestAccRepositoryConfAnalysisResource
--- PASS: TestAccRepositoryConfAnalysisResource (9.07s)
PASS
ok  	github.com/cyralinc/terraform-provider-cyral/cyral/internal/repository/confanalysis	9.433s
=== RUN   TestAccRepositoryConfAuthResource
=== PAUSE TestAccRepositoryConfAuthResource
=== RUN   TestRepositoryConfAuthResourceUpgradeV0
--- PASS: TestRepositoryConfAuthResourceUpgradeV0 (0.00s)
=== CONT  TestAccRepositoryConfAuthResource
--- PASS: TestAccRepositoryConfAuthResource (15.68s)
PASS
ok  	github.com/cyralinc/terraform-provider-cyral/cyral/internal/repository/confauth	16.053s
=== RUN   TestAccRepositoryDatamapResource
=== PAUSE TestAccRepositoryDatamapResource
=== CONT  TestAccRepositoryDatamapResource
--- PASS: TestAccRepositoryDatamapResource (21.83s)
PASS
ok  	github.com/cyralinc/terraform-provider-cyral/cyral/internal/repository/datamap	22.167s
=== RUN   TestAccRepositoryNetworkAccessPolicyResource
=== PAUSE TestAccRepositoryNetworkAccessPolicyResource
=== CONT  TestAccRepositoryNetworkAccessPolicyResource
--- PASS: TestAccRepositoryNetworkAccessPolicyResource (22.76s)
PASS
ok  	github.com/cyralinc/terraform-provider-cyral/cyral/internal/repository/network	23.090s
=== RUN   TestAccRepositoryUserAccountResource
=== PAUSE TestAccRepositoryUserAccountResource
=== CONT  TestAccRepositoryUserAccountResource
--- PASS: TestAccRepositoryUserAccountResource (44.98s)
PASS
ok  	github.com/cyralinc/terraform-provider-cyral/cyral/internal/repository/useraccount	45.417s
=== RUN   TestAccRoleDataSource
=== PAUSE TestAccRoleDataSource
=== RUN   TestAccRoleSSOGroupsResource
=== PAUSE TestAccRoleSSOGroupsResource
=== RUN   TestRoleSSOGroupsResourceUpgradeV0
--- PASS: TestRoleSSOGroupsResourceUpgradeV0 (0.00s)
=== RUN   TestAccRoleResource
=== PAUSE TestAccRoleResource
=== CONT  TestAccRoleDataSource
=== CONT  TestAccRoleSSOGroupsResource
=== CONT  TestAccRoleResource
--- PASS: TestAccRoleDataSource (7.59s)
--- PASS: TestAccRoleSSOGroupsResource (14.71s)
--- PASS: TestAccRoleResource (20.92s)
PASS
ok  	github.com/cyralinc/terraform-provider-cyral/cyral/internal/role	21.254s
=== RUN   TestAccSAMLCertificateDataSource
=== PAUSE TestAccSAMLCertificateDataSource
=== CONT  TestAccSAMLCertificateDataSource
--- PASS: TestAccSAMLCertificateDataSource (5.45s)
PASS
ok  	github.com/cyralinc/terraform-provider-cyral/cyral/internal/samlcertificate	5.784s
=== RUN   TestAccSAMLConfigurationDataSource
=== PAUSE TestAccSAMLConfigurationDataSource
=== CONT  TestAccSAMLConfigurationDataSource
--- PASS: TestAccSAMLConfigurationDataSource (10.14s)
PASS
ok  	github.com/cyralinc/terraform-provider-cyral/cyral/internal/samlconfiguration	10.481s
=== RUN   TestAccServiceAccountResource
=== PAUSE TestAccServiceAccountResource
=== CONT  TestAccServiceAccountResource
--- PASS: TestAccServiceAccountResource (22.22s)
PASS
ok  	github.com/cyralinc/terraform-provider-cyral/cyral/internal/serviceaccount	22.572s
=== RUN   TestAccSidecarBoundPortsDataSource
=== PAUSE TestAccSidecarBoundPortsDataSource
=== RUN   TestAccSidecarIDDataSource
=== PAUSE TestAccSidecarIDDataSource
=== RUN   TestAccSidecarResource
=== PAUSE TestAccSidecarResource
=== CONT  TestAccSidecarBoundPortsDataSource
=== CONT  TestAccSidecarResource
=== CONT  TestAccSidecarIDDataSource
--- PASS: TestAccSidecarIDDataSource (6.69s)
--- PASS: TestAccSidecarBoundPortsDataSource (13.61s)
--- PASS: TestAccSidecarResource (26.73s)
PASS
ok  	github.com/cyralinc/terraform-provider-cyral/cyral/internal/sidecar	27.065s
=== RUN   TestAccSidecarCredentialsResource
=== PAUSE TestAccSidecarCredentialsResource
=== CONT  TestAccSidecarCredentialsResource
--- PASS: TestAccSidecarCredentialsResource (5.59s)
PASS
ok  	github.com/cyralinc/terraform-provider-cyral/cyral/internal/sidecar/credentials	5.933s
=== RUN   TestAccSidecarHealthDataSource
=== PAUSE TestAccSidecarHealthDataSource
=== CONT  TestAccSidecarHealthDataSource
--- PASS: TestAccSidecarHealthDataSource (5.72s)
PASS
ok  	github.com/cyralinc/terraform-provider-cyral/cyral/internal/sidecar/health	6.062s
=== RUN   TestAccSidecarInstanceStatsDataSource
=== PAUSE TestAccSidecarInstanceStatsDataSource
=== RUN   TestAccSidecarInstanceDataSource
=== PAUSE TestAccSidecarInstanceDataSource
=== CONT  TestAccSidecarInstanceStatsDataSource
=== CONT  TestAccSidecarInstanceDataSource
--- PASS: TestAccSidecarInstanceStatsDataSource (4.25s)
--- PASS: TestAccSidecarInstanceDataSource (7.30s)
PASS
ok  	github.com/cyralinc/terraform-provider-cyral/cyral/internal/sidecar/instance	7.632s
=== RUN   TestAccSidecarListenerDataSource
=== PAUSE TestAccSidecarListenerDataSource
=== RUN   TestSidecarListenerResource
=== PAUSE TestSidecarListenerResource
=== CONT  TestAccSidecarListenerDataSource
=== CONT  TestSidecarListenerResource
--- PASS: TestAccSidecarListenerDataSource (18.02s)
--- PASS: TestSidecarListenerResource (34.67s)
PASS
ok  	github.com/cyralinc/terraform-provider-cyral/cyral/internal/sidecar/listener	35.032s
testing: warning: no tests to run
PASS
ok  	github.com/cyralinc/terraform-provider-cyral/cyral/internal/sweep	(cached) [no tests to run]
=== RUN   TestAccSystemInfoDataSource
=== PAUSE TestAccSystemInfoDataSource
=== CONT  TestAccSystemInfoDataSource
--- PASS: TestAccSystemInfoDataSource (4.45s)
PASS
ok  	github.com/cyralinc/terraform-provider-cyral/cyral/internal/systeminfo	4.778s
=== RUN   TestAccAccessTokenSettingsResource
=== PAUSE TestAccAccessTokenSettingsResource
=== CONT  TestAccAccessTokenSettingsResource
--- PASS: TestAccAccessTokenSettingsResource (15.07s)
PASS
ok  	github.com/cyralinc/terraform-provider-cyral/cyral/internal/tokensettings	15.398s
=== RUN   TestAccProvider
2023/11/29 17:02:41 [DEBUG] Init getDataSourceMap
2023/11/29 17:02:41 [DEBUG] Looking for datasources in package `datalabel`
2023/11/29 17:02:41 [DEBUG] Registering datasources `cyral_datalabel`
2023/11/29 17:02:41 [DEBUG] Looking for datasources in package `datamap`
2023/11/29 17:02:41 [DEBUG] Looking for datasources in package `tokensettings`
2023/11/29 17:02:41 [DEBUG] Registering datasources `cyral_access_token_settings`
2023/11/29 17:02:41 [DEBUG] Init dataSourceSidecarListener
2023/11/29 17:02:41 [DEBUG] End dataSourceSidecarListener
2023/11/29 17:02:41 [DEBUG] end getDataSourceMap
2023/11/29 17:02:41 [DEBUG] Init getResourceMap
2023/11/29 17:02:41 [DEBUG] Looking for resources in package `datalabel`
2023/11/29 17:02:41 [DEBUG] Registering resources `cyral_datalabel`
2023/11/29 17:02:41 [DEBUG] Looking for resources in package `datamap`
2023/11/29 17:02:41 [DEBUG] Registering resources `cyral_repository_datamap`
2023/11/29 17:02:41 [DEBUG] Looking for resources in package `tokensettings`
2023/11/29 17:02:41 [DEBUG] Registering resources `cyral_access_token_settings`
2023/11/29 17:02:41 [DEBUG] End getResourceMap
--- PASS: TestAccProvider (0.00s)
PASS
ok  	github.com/cyralinc/terraform-provider-cyral/cyral/provider	0.284s
=== RUN   TestElementsMatch
--- PASS: TestElementsMatch (0.00s)
PASS
ok  	github.com/cyralinc/terraform-provider-cyral/cyral/utils	(cached)

@VictorGFM VictorGFM marked this pull request as ready for review November 20, 2023 16:55
@VictorGFM VictorGFM force-pushed the feature/ENG-12954/ENG-12955 branch from b817177 to 3bad73d Compare November 20, 2023 19:47
wcmjunior
wcmjunior reviewed Nov 21, 2023
View reviewed changes
cyral/utils/utils.go Outdated Show resolved Hide resolved
cyral/internal/tokensettings/resource.go Outdated Show resolved Hide resolved
@VictorGFM VictorGFM requested a review from wcmjunior November 29, 2023 20:08
wcmjunior
wcmjunior approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@wcmjunior wcmjunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Please see the suggestion to rename the resource name from name to current to make it easier for users to copy and paste in their code.

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@VictorGFM VictorGFM merged commit 328aac1 into main Nov 29, 2023
3 checks passed
@VictorGFM VictorGFM deleted the feature/ENG-12954/ENG-12955 branch November 29, 2023 20:34
@wcmjunior
Copy link
Contributor

Thanks for your contribution @VictorGFM! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wcmjunior wcmjunior wcmjunior approved these changes

@ptcar2009 ptcar2009 Awaiting requested review from ptcar2009

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VictorGFM @wcmjunior