Removing the helm and cloudFormation sidecar deployment types

[salgattcy]

Description of the change

Removing the helm deployment type and changing cloudFormation to cft-ec2 to be in line with what is currently used when using the UI.

Type of change

• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists

Development

• Lint rules pass locally
• The code changed/added as part of this pull request has been covered with tests
• All tests related to the changed code pass in development

Code review

• This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
• Jira issue referenced in commit message and/or PR title

Testing

Ran make locally and the changed tests passed

[VictorGFM]

@salgattcy changes are looking good, could you please rebase this branch on top of main and re-generate the docs to make sure they are all up to date? I believe we need to update the docs for the sidecar_cft_template data source. Thanks for working on this fix btw.

[wcmjunior]

@VictorGFM , I don't see any conflicts. Why rebase?

[VictorGFM]

@wcmjunior In this PR we changed how metadata (the provider name to be more specific) is generated on the resource/data source docs, this was made to avoid generating unnecessary changes when running the tfplugindocs locally vs through docker. So the idea is to rebase and re-generate the docs to reflect these changes, even though there is no conflict with the main branch.

[salgattcy]

@salgattcy changes are looking good, could you please rebase this branch on top of main and re-generate the docs to make sure they are all up to date? I believe we need to update the docs for the sidecar_cft_template data source. Thanks for working on this fix btw.

Let's see if I did this all correctly 😬

[wcmjunior]

@wcmjunior In this PR we changed how metadata (the provider name to be more specific) is generated on the resource/data source docs, this was made to avoid generating unnecessary changes when running the tfplugindocs locally vs through docker. So the idea is to rebase and re-generate the docs to reflect these changes, even though there is no conflict with the main branch.

Still doesn't make sense. There are no conflicts and the docs should look the same after being regenerated.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[VictorGFM]

LGTM!