Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3 guide #429

Merged
merged 3 commits into from
Oct 20, 2023
Merged

S3 guide #429

merged 3 commits into from
Oct 20, 2023

Conversation

wcmjunior
Copy link
Contributor

@wcmjunior wcmjunior commented Aug 2, 2023 •
edited
Loading

Description of the change

A new guide to assist users deploying S3 sidecars.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Jira issue referenced in commit message and/or PR title

Testing

Deployed a sidecar that with support for both S3 browser and CLI.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wcmjunior wcmjunior marked this pull request as ready for review October 19, 2023 23:12
@wcmjunior wcmjunior requested a review from VictorGFM October 19, 2023 23:13
VictorGFM
VictorGFM approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@VictorGFM VictorGFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very complete guide, well done! Lets just make sure to remove the duplicated files before merging

docs/guides/s3_browser_and_aws_cli Outdated Show resolved Hide resolved
templates/guides/s3_browser_and_aws_cli.tmpl Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wcmjunior wcmjunior merged commit adf453c into main Oct 20, 2023
3 checks passed
@wcmjunior wcmjunior deleted the feat/s3-guide branch October 20, 2023 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VictorGFM VictorGFM VictorGFM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wcmjunior @VictorGFM