Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-14432: Unregisters disabled services from local registry #28

Merged
merged 11 commits into from
Oct 1, 2024

Conversation

ptcar2009
Copy link
Contributor

@ptcar2009 ptcar2009 commented Sep 30, 2024

Description

Removes disabled services from local registry so they don't report to the CP as unhealthy.

Testing

Deployed with the CLi installed and without it and both worked perfectly.

@ptcar2009 ptcar2009 requested a review from wcmjunior October 1, 2024 20:37
Copy link
Contributor

@yoursnerdly yoursnerdly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - please see the minor comment.

install-linux.sh Show resolved Hide resolved
@ptcar2009 ptcar2009 marked this pull request as ready for review October 1, 2024 21:00
@ptcar2009 ptcar2009 requested a review from yoursnerdly October 1, 2024 22:33
Copy link
Contributor

@yoursnerdly yoursnerdly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wcmjunior wcmjunior merged commit 8bf19b1 into main Oct 1, 2024
1 check passed
@wcmjunior wcmjunior deleted the ENG-14432 branch October 1, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants