ENG-14344: Configures storage manager and service endpoints #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
September 18, 2024 17:50
yoursnerdly
reviewed
Sep 20, 2024
yoursnerdly
approved these changes
Sep 20, 2024
wcmjunior
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Configures the storage manager service if available and enabled.
Testing
Deployed a v4.14 sidecar and it worked properly. Deployed a sidecar with
storage manager available and enabled and it configured itself correctly.
Deployed a sidecar with storage manager available but disabled and it
worked correctly, without the sm service.