Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for rocky linux and script cleanup #21

Merged
merged 7 commits into from
Feb 2, 2024
Merged

Add support for rocky linux and script cleanup #21

merged 7 commits into from
Feb 2, 2024

Conversation

jrich523
Copy link
Contributor

@jrich523 jrich523 commented Jan 5, 2024

Additional changes related to 4.11 for new services

Tested on 4.8 and 4.11 with clean install and re-install for rocky/cent/aws/ubuntu

@gabfelp
Copy link
Contributor

gabfelp commented Jan 25, 2024

@jrich523 your installation script looks fine:
image

I also added a small commit for changing route to get files from e26c8e0

@gabfelp
Copy link
Contributor

gabfelp commented Jan 25, 2024

Making tests with this code deploying on ubuntu, Sidecar v4.12.2:

image

cc: @jrich523

@gabfelp
Copy link
Contributor

gabfelp commented Jan 26, 2024

Tests after commit 4e3f4d5

Running the script with export CYRAL_SIDECAR_VERSION="v4.12.2" I do see correct behavior:

image

Running it with export CYRAL_SIDECAR_VERSION="v4.6.0":

image

cc: @jrich523

@jrich523 jrich523 merged commit e34a9ce into main Feb 2, 2024
1 check passed
@jrich523 jrich523 deleted the rocky branch February 2, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants