Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current CRAN check results
Checked on 2024-11-24, problems found: https://cran.r-project.org/web/checks/check_results_dm.html
NOTE: r-devel-linux-x86_64-debian-clang, r-devel-linux-x86_64-debian-gcc, r-devel-windows-x86_64
Found the following Rd file(s) with Rd \link{} targets missing package
anchors:
dm_examine_cardinalities.Rd: as_tibble
dm_examine_constraints.Rd: as_tibble
dm_from_con.Rd: src
dm_zoom_to.Rd: nest_join
json_nest.Rd: tidyr_tidy_select
json_pack.Rd: tidyr_tidy_select
Please provide package anchors for all Rd \link{} targets not in the
package itself and the base packages.
ERROR: r-devel-linux-x86_64-debian-clang
Running ‘testthat.R’ [154s/81s]
Running the tests in ‘tests/testthat.R’ failed.
Complete output:
Attaching package: 'dm'
The following object is masked from 'package:stats':
filter
Starting 2 test processes
[ FAIL 1 | WARN 0 | SKIP 242 | PASS 1355 ]
══ Skipped tests (242) ═════════════════════════════════════════════════════════
• COMPOUND (1): 'test-rows-dm.R:203:3'
• Dependent on database version, find better way to record this info (1):
'test-meta.R:19:3'
• FIXME (2): 'test-learn.R:154:3', 'test-nest.R:2:3'
• FIXME: Unstable on GHA? (1): 'test-dm.R:495:3'
• Need to think about it (1): 'test-key-helpers.R:45:3'
• On CRAN (191): 'test-zzx-deprecated.R:2:3', 'test-zzx-deprecated.R:15:3',
'test-zzx-deprecated.R:25:3', 'test-zzx-deprecated.R:35:3',
'test-zzx-deprecated.R:45:3', 'test-zzx-deprecated.R:58:3',
'test-zzx-deprecated.R:81:3', 'test-zzx-deprecated.R:91:3',
'test-zzx-deprecated.R:106:3', 'test-zzx-deprecated.R:121:3',
'test-zzx-deprecated.R:141:3', 'test-zzx-deprecated.R:151:3',
'test-zzx-deprecated.R:166:3', 'test-zzx-deprecated.R:185:3',
'test-zzx-deprecated.R:221:3', 'test-zzx-deprecated.R:255:3',
'test-zzx-deprecated.R:275:3', 'test-zzx-deprecated.R:291:3',
'test-zzx-deprecated.R:326:3', 'test-zzx-deprecated.R:341:3',
'test-zzx-deprecated.R:356:3', 'test-flatten.R:18:3', 'test-flatten.R:99:3',
'test-dplyr.R:347:3', 'test-dplyr.R:506:3', 'test-dplyr.R:545:3',
'test-dplyr.R:558:3', 'test-dplyr.R:569:3', 'test-dplyr.R:598:3',
'test-dplyr.R:614:3', 'test-dplyr.R:806:3', 'test-draw-dm.R:17:3',
'test-draw-dm.R:104:3', 'test-draw-dm.R:117:3', 'test-draw-dm.R:153:3',
'test-draw-dm.R:182:3', 'test-filter-dm.R:62:3
ERROR: r-devel-linux-x86_64-debian-gcc
Running ‘testthat.R’ [114s/89s]
Running the tests in ‘tests/testthat.R’ failed.
Complete output:
Attaching package: 'dm'
The following object is masked from 'package:stats':
filter
Starting 2 test processes
[ FAIL 1 | WARN 0 | SKIP 242 | PASS 1355 ]
══ Skipped tests (242) ═════════════════════════════════════════════════════════
• COMPOUND (1): 'test-rows-dm.R:203:3'
• Dependent on database version, find better way to record this info (1):
'test-meta.R:19:3'
• FIXME (2): 'test-learn.R:154:3', 'test-nest.R:2:3'
• FIXME: Unstable on GHA? (1): 'test-dm.R:495:3'
• Need to think about it (1): 'test-key-helpers.R:45:3'
• On CRAN (191): 'test-zzx-deprecated.R:2:3', 'test-zzx-deprecated.R:15:3',
'test-zzx-deprecated.R:25:3', 'test-zzx-deprecated.R:35:3',
'test-zzx-deprecated.R:45:3', 'test-zzx-deprecated.R:58:3',
'test-zzx-deprecated.R:81:3', 'test-zzx-deprecated.R:91:3',
'test-zzx-deprecated.R:106:3', 'test-zzx-deprecated.R:121:3',
'test-zzx-deprecated.R:141:3', 'test-zzx-deprecated.R:151:3',
'test-zzx-deprecated.R:166:3', 'test-zzx-deprecated.R:185:3',
'test-zzx-deprecated.R:221:3', 'test-zzx-deprecated.R:255:3',
'test-zzx-deprecated.R:275:3', 'test-zzx-deprecated.R:291:3',
'test-zzx-deprecated.R:326:3', 'test-zzx-deprecated.R:341:3',
'test-zzx-deprecated.R:356:3', 'test-flatten.R:18:3', 'test-flatten.R:99:3',
'test-dplyr.R:347:3', 'test-dplyr.R:506:3', 'test-dplyr.R:545:3',
'test-dplyr.R:558:3', 'test-dplyr.R:569:3', 'test-dplyr.R:598:3',
'test-dplyr.R:614:3', 'test-dplyr.R:806:3', 'test-draw-dm.R:17:3',
'test-draw-dm.R:104:3', 'test-draw-dm.R:117:3', 'test-draw-dm.R:153:3',
'test-draw-dm.R:182:3', 'test-filter-dm.R:62:3
ERROR: r-devel-linux-x86_64-fedora-clang
Running ‘testthat.R’ [267s/144s]
Running the tests in ‘tests/testthat.R’ failed.
Complete output:
Attaching package: 'dm'
The following object is masked from 'package:stats':
filter
Starting 2 test processes
[ FAIL 1 | WARN 0 | SKIP 242 | PASS 1355 ]
══ Skipped tests (242) ═════════════════════════════════════════════════════════
• COMPOUND (1): 'test-rows-dm.R:203:3'
• Dependent on database version, find better way to record this info (1):
'test-meta.R:19:3'
• FIXME (2): 'test-learn.R:154:3', 'test-nest.R:2:3'
• FIXME: Unstable on GHA? (1): 'test-dm.R:495:3'
• Need to think about it (1): 'test-key-helpers.R:45:3'
• On CRAN (191): 'test-zzx-deprecated.R:2:3', 'test-zzx-deprecated.R:15:3',
'test-zzx-deprecated.R:25:3', 'test-zzx-deprecated.R:35:3',
'test-zzx-deprecated.R:45:3', 'test-zzx-deprecated.R:58:3',
'test-zzx-deprecated.R:81:3', 'test-zzx-deprecated.R:91:3',
'test-zzx-deprecated.R:106:3', 'test-zzx-deprecated.R:121:3',
'test-zzx-deprecated.R:141:3', 'test-zzx-deprecated.R:151:3',
'test-zzx-deprecated.R:166:3', 'test-zzx-deprecated.R:185:3',
'test-zzx-deprecated.R:221:3', 'test-zzx-deprecated.R:255:3',
'test-zzx-deprecated.R:275:3', 'test-zzx-deprecated.R:291:3',
'test-zzx-deprecated.R:326:3', 'test-zzx-deprecated.R:341:3',
'test-zzx-deprecated.R:356:3', 'test-flatten.R:18:3', 'test-flatten.R:99:3',
'test-dplyr.R:347:3', 'test-dplyr.R:506:3', 'test-dplyr.R:545:3',
'test-dplyr.R:558:3', 'test-dplyr.R:569:3', 'test-dplyr.R:598:3',
'test-dplyr.R:614:3', 'test-dplyr.R:806:3', 'test-draw-dm.R:17:3',
'test-draw-dm.R:104:3', 'test-draw-dm.R:117:3', 'test-draw-dm.R:153:3',
'test-draw-dm.R:182:3', 'test-filter-dm.R:62:
ERROR: r-devel-linux-x86_64-fedora-gcc
Running ‘testthat.R’ [261s/149s]
Running the tests in ‘tests/testthat.R’ failed.
Complete output:
Attaching package: 'dm'
The following object is masked from 'package:stats':
filter
Starting 2 test processes
[ FAIL 1 | WARN 0 | SKIP 242 | PASS 1355 ]
══ Skipped tests (242) ═════════════════════════════════════════════════════════
• COMPOUND (1): 'test-rows-dm.R:203:3'
• Dependent on database version, find better way to record this info (1):
'test-meta.R:19:3'
• FIXME (2): 'test-learn.R:154:3', 'test-nest.R:2:3'
• FIXME: Unstable on GHA? (1): 'test-dm.R:495:3'
• Need to think about it (1): 'test-key-helpers.R:45:3'
• On CRAN (191): 'test-zzx-deprecated.R:2:3', 'test-zzx-deprecated.R:15:3',
'test-zzx-deprecated.R:25:3', 'test-zzx-deprecated.R:35:3',
'test-zzx-deprecated.R:45:3', 'test-zzx-deprecated.R:58:3',
'test-zzx-deprecated.R:81:3', 'test-zzx-deprecated.R:91:3',
'test-zzx-deprecated.R:106:3', 'test-zzx-deprecated.R:121:3',
'test-zzx-deprecated.R:141:3', 'test-zzx-deprecated.R:151:3',
'test-zzx-deprecated.R:166:3', 'test-zzx-deprecated.R:185:3',
'test-zzx-deprecated.R:221:3', 'test-zzx-deprecated.R:255:3',
'test-zzx-deprecated.R:275:3', 'test-zzx-deprecated.R:291:3',
'test-zzx-deprecated.R:326:3', 'test-zzx-deprecated.R:341:3',
'test-zzx-deprecated.R:356:3', 'test-flatten.R:18:3', 'test-flatten.R:99:3',
'test-dplyr.R:347:3', 'test-dplyr.R:506:3', 'test-dplyr.R:545:3',
'test-dplyr.R:558:3', 'test-dplyr.R:569:3', 'test-dplyr.R:598:3',
'test-dplyr.R:614:3', 'test-dplyr.R:806:3', 'test-draw-dm.R:17:3',
'test-draw-dm.R:104:3', 'test-draw-dm.R:117:3', 'test-draw-dm.R:153:3',
'test-draw-dm.R:182:3', 'test-filter-dm.R:62:
ERROR: r-devel-windows-x86_64
Running 'testthat.R' [67s]
Running the tests in 'tests/testthat.R' failed.
Complete output:
Attaching package: 'dm'
The following object is masked from 'package:stats':
filter
Starting 2 test processes
[ FAIL 1 | WARN 0 | SKIP 242 | PASS 1355 ]
══ Skipped tests (242) ═════════════════════════════════════════════════════════
• COMPOUND (1): 'test-rows-dm.R:203:3'
• Dependent on database version, find better way to record this info (1):
'test-meta.R:19:3'
• FIXME (2): 'test-learn.R:154:3', 'test-nest.R:2:3'
• FIXME: Unstable on GHA? (1): 'test-dm.R:495:3'
• Need to think about it (1): 'test-key-helpers.R:45:3'
• On CRAN (191): 'test-zzx-deprecated.R:2:3', 'test-zzx-deprecated.R:15:3',
'test-zzx-deprecated.R:25:3', 'test-zzx-deprecated.R:35:3',
'test-zzx-deprecated.R:45:3', 'test-zzx-deprecated.R:58:3',
'test-zzx-deprecated.R:81:3', 'test-zzx-deprecated.R:91:3',
'test-zzx-deprecated.R:106:3', 'test-zzx-deprecated.R:121:3',
'test-zzx-deprecated.R:141:3', 'test-zzx-deprecated.R:151:3',
'test-zzx-deprecated.R:166:3', 'test-zzx-deprecated.R:185:3',
'test-zzx-deprecated.R:221:3', 'test-zzx-deprecated.R:255:3',
'test-zzx-deprecated.R:275:3', 'test-zzx-deprecated.R:291:3',
'test-zzx-deprecated.R:326:3', 'test-zzx-deprecated.R:341:3',
'test-zzx-deprecated.R:356:3', 'test-flatten.R:18:3', 'test-flatten.R:99:3',
'test-dplyr.R:347:3', 'test-dplyr.R:506:3', 'test-dplyr.R:545:3',
'test-dplyr.R:558:3', 'test-dplyr.R:569:3', 'test-dplyr.R:598:3',
'test-dplyr.R:614:3', 'test-dplyr.R:806:3', 'test-draw-dm.R:17:3',
'test-draw-dm.R:104:3', 'test-draw-dm.R:117:3', 'test-draw-dm.R:153:3',
'test-draw-dm.R:182:3', 'test-filter-dm.R:62:3', 't
ERROR: r-patched-linux-x86_64
Running ‘testthat.R’ [150s/79s]
Running the tests in ‘tests/testthat.R’ failed.
Complete output:
Attaching package: 'dm'
The following object is masked from 'package:stats':
filter
Starting 2 test processes
[ FAIL 1 | WARN 0 | SKIP 242 | PASS 1355 ]
══ Skipped tests (242) ═════════════════════════════════════════════════════════
• COMPOUND (1): 'test-rows-dm.R:203:3'
• Dependent on database version, find better way to record this info (1):
'test-meta.R:19:3'
• FIXME (2): 'test-learn.R:154:3', 'test-nest.R:2:3'
• FIXME: Unstable on GHA? (1): 'test-dm.R:495:3'
• Need to think about it (1): 'test-key-helpers.R:45:3'
• On CRAN (191): 'test-zzx-deprecated.R:2:3', 'test-zzx-deprecated.R:15:3',
'test-zzx-deprecated.R:25:3', 'test-zzx-deprecated.R:35:3',
'test-zzx-deprecated.R:45:3', 'test-zzx-deprecated.R:58:3',
'test-zzx-deprecated.R:81:3', 'test-zzx-deprecated.R:91:3',
'test-zzx-deprecated.R:106:3', 'test-zzx-deprecated.R:121:3',
'test-zzx-deprecated.R:141:3', 'test-zzx-deprecated.R:151:3',
'test-zzx-deprecated.R:166:3', 'test-zzx-deprecated.R:185:3',
'test-zzx-deprecated.R:221:3', 'test-zzx-deprecated.R:255:3',
'test-zzx-deprecated.R:275:3', 'test-zzx-deprecated.R:291:3',
'test-zzx-deprecated.R:326:3', 'test-zzx-deprecated.R:341:3',
'test-zzx-deprecated.R:356:3', 'test-flatten.R:18:3', 'test-flatten.R:99:3',
'test-dplyr.R:347:3', 'test-dplyr.R:506:3', 'test-dplyr.R:545:3',
'test-dplyr.R:558:3', 'test-dplyr.R:569:3', 'test-dplyr.R:598:3',
'test-dplyr.R:614:3', 'test-dplyr.R:806:3', 'test-draw-dm.R:17:3',
'test-draw-dm.R:104:3', 'test-draw-dm.R:117:3', 'test-draw-dm.R:153:3',
'test-draw-dm.R:182:3', 'test-filter-dm.R:62:3
ERROR: r-release-linux-x86_64
Running ‘testthat.R’ [153s/82s]
Running the tests in ‘tests/testthat.R’ failed.
Complete output:
Attaching package: 'dm'
The following object is masked from 'package:stats':
filter
Starting 2 test processes
[ FAIL 1 | WARN 0 | SKIP 242 | PASS 1355 ]
══ Skipped tests (242) ═════════════════════════════════════════════════════════
• COMPOUND (1): 'test-rows-dm.R:203:3'
• Dependent on database version, find better way to record this info (1):
'test-meta.R:19:3'
• FIXME (2): 'test-learn.R:154:3', 'test-nest.R:2:3'
• FIXME: Unstable on GHA? (1): 'test-dm.R:495:3'
• Need to think about it (1): 'test-key-helpers.R:45:3'
• On CRAN (191): 'test-zzx-deprecated.R:2:3', 'test-zzx-deprecated.R:15:3',
'test-zzx-deprecated.R:25:3', 'test-zzx-deprecated.R:35:3',
'test-zzx-deprecated.R:45:3', 'test-zzx-deprecated.R:58:3',
'test-zzx-deprecated.R:81:3', 'test-zzx-deprecated.R:91:3',
'test-zzx-deprecated.R:106:3', 'test-zzx-deprecated.R:121:3',
'test-zzx-deprecated.R:141:3', 'test-zzx-deprecated.R:151:3',
'test-zzx-deprecated.R:166:3', 'test-zzx-deprecated.R:185:3',
'test-zzx-deprecated.R:221:3', 'test-zzx-deprecated.R:255:3',
'test-zzx-deprecated.R:275:3', 'test-zzx-deprecated.R:291:3',
'test-zzx-deprecated.R:326:3', 'test-zzx-deprecated.R:341:3',
'test-zzx-deprecated.R:356:3', 'test-flatten.R:18:3', 'test-flatten.R:99:3',
'test-dplyr.R:347:3', 'test-dplyr.R:506:3', 'test-dplyr.R:545:3',
'test-dplyr.R:558:3', 'test-dplyr.R:569:3', 'test-dplyr.R:598:3',
'test-dplyr.R:614:3', 'test-dplyr.R:806:3', 'test-draw-dm.R:17:3',
'test-draw-dm.R:104:3', 'test-draw-dm.R:117:3', 'test-draw-dm.R:153:3',
'test-draw-dm.R:182:3', 'test-filter-dm.R:62:3
ERROR: r-release-windows-x86_64
Running 'testthat.R' [68s]
Running the tests in 'tests/testthat.R' failed.
Complete output:
Attaching package: 'dm'
The following object is masked from 'package:stats':
filter
Starting 2 test processes
[ FAIL 1 | WARN 0 | SKIP 242 | PASS 1355 ]
══ Skipped tests (242) ═════════════════════════════════════════════════════════
• COMPOUND (1): 'test-rows-dm.R:203:3'
• Dependent on database version, find better way to record this info (1):
'test-meta.R:19:3'
• FIXME (2): 'test-learn.R:154:3', 'test-nest.R:2:3'
• FIXME: Unstable on GHA? (1): 'test-dm.R:495:3'
• Need to think about it (1): 'test-key-helpers.R:45:3'
• On CRAN (191): 'test-zzx-deprecated.R:2:3', 'test-zzx-deprecated.R:15:3',
'test-zzx-deprecated.R:25:3', 'test-zzx-deprecated.R:35:3',
'test-zzx-deprecated.R:45:3', 'test-zzx-deprecated.R:58:3',
'test-zzx-deprecated.R:81:3', 'test-zzx-deprecated.R:91:3',
'test-zzx-deprecated.R:106:3', 'test-zzx-deprecated.R:121:3',
'test-zzx-deprecated.R:141:3', 'test-zzx-deprecated.R:151:3',
'test-zzx-deprecated.R:166:3', 'test-zzx-deprecated.R:185:3',
'test-zzx-deprecated.R:221:3', 'test-zzx-deprecated.R:255:3',
'test-zzx-deprecated.R:275:3', 'test-zzx-deprecated.R:291:3',
'test-zzx-deprecated.R:326:3', 'test-zzx-deprecated.R:341:3',
'test-zzx-deprecated.R:356:3', 'test-flatten.R:18:3', 'test-flatten.R:99:3',
'test-dplyr.R:347:3', 'test-dplyr.R:506:3', 'test-dplyr.R:545:3',
'test-dplyr.R:558:3', 'test-dplyr.R:569:3', 'test-dplyr.R:598:3',
'test-dplyr.R:614:3', 'test-dplyr.R:806:3', 'test-draw-dm.R:17:3',
'test-draw-dm.R:104:3', 'test-draw-dm.R:117:3', 'test-draw-dm.R:153:3',
'test-draw-dm.R:182:3', 'test-filter-dm.R:62:3', 't
ERROR: r-oldrel-windows-x86_64
Running 'testthat.R' [100s]
Running the tests in 'tests/testthat.R' failed.
Complete output:
Attaching package: 'dm'
The following object is masked from 'package:stats':
filter
Starting 2 test processes
[ FAIL 1 | WARN 0 | SKIP 242 | PASS 1355 ]
══ Skipped tests (242) ═════════════════════════════════════════════════════════
• COMPOUND (1): 'test-rows-dm.R:203:3'
• Dependent on database version, find better way to record this info (1):
'test-meta.R:19:3'
• FIXME (2): 'test-learn.R:154:3', 'test-nest.R:2:3'
• FIXME: Unstable on GHA? (1): 'test-dm.R:495:3'
• Need to think about it (1): 'test-key-helpers.R:45:3'
• On CRAN (191): 'test-zzx-deprecated.R:2:3', 'test-zzx-deprecated.R:15:3',
'test-zzx-deprecated.R:25:3', 'test-zzx-deprecated.R:35:3',
'test-zzx-deprecated.R:45:3', 'test-zzx-deprecated.R:58:3',
'test-zzx-deprecated.R:81:3', 'test-zzx-deprecated.R:91:3',
'test-zzx-deprecated.R:106:3', 'test-zzx-deprecated.R:121:3',
'test-zzx-deprecated.R:141:3', 'test-zzx-deprecated.R:151:3',
'test-zzx-deprecated.R:166:3', 'test-zzx-deprecated.R:185:3',
'test-zzx-deprecated.R:221:3', 'test-zzx-deprecated.R:255:3',
'test-zzx-deprecated.R:275:3', 'test-zzx-deprecated.R:291:3',
'test-zzx-deprecated.R:326:3', 'test-zzx-deprecated.R:341:3',
'test-zzx-deprecated.R:356:3', 'test-flatten.R:18:3', 'test-flatten.R:99:3',
'test-dplyr.R:347:3', 'test-dplyr.R:506:3', 'test-dplyr.R:545:3',
'test-dplyr.R:558:3', 'test-dplyr.R:569:3', 'test-dplyr.R:598:3',
'test-dplyr.R:614:3', 'test-dplyr.R:806:3', 'test-draw-dm.R:17:3',
'test-draw-dm.R:104:3', 'test-draw-dm.R:117:3', 'test-draw-dm.R:153:3',
'test-draw-dm.R:182:3', 'test-filter-dm.R:62:3', '
Check results at: https://cran.r-project.org/web/checks/check_results_dm.html
Action items
fledge::release()
fledge::post_release()