Cleanup

cynkra · Oct 30, 2023 · dc44949 · dc44949
1 parent ff2261a
commit dc44949
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 18 deletions.
diff --git a/tests/testthat/test-duckdb.R b/tests/testthat/test-duckdb.R
@@ -8,9 +8,6 @@ test_that("dm_sql()", {
   # Need skip in every test block, unfortunately
   skip_if_src_not("duckdb")
 
-  # https://github.com/tidyverse/dbplyr/pull/1190
-  skip_if(is(my_test_con(), "MySQLConnection"))
-
   expect_snapshot({
     dm_for_filter_df() %>%
       dm_sql(my_test_con())

diff --git a/tests/testthat/test-maria.R b/tests/testthat/test-maria.R
@@ -8,9 +8,6 @@ test_that("dm_sql()", {
   # Need skip in every test block, unfortunately
   skip_if_src_not("maria")
 
-  # https://github.com/tidyverse/dbplyr/pull/1190
-  skip_if(is(my_test_con(), "MySQLConnection"))
-
   expect_snapshot({
     dm_for_filter_df() %>%
       dm_sql(my_test_con())

diff --git a/tests/testthat/test-mssql.R b/tests/testthat/test-mssql.R
@@ -8,9 +8,6 @@ test_that("dm_sql()", {
   # Need skip in every test block, unfortunately
   skip_if_src_not("mssql")
 
-  # https://github.com/tidyverse/dbplyr/pull/1190
-  skip_if(is(my_test_con(), "MySQLConnection"))
-
   expect_snapshot({
     dm_for_filter_df() %>%
       dm_sql(my_test_con())

diff --git a/tests/testthat/test-mysql.R b/tests/testthat/test-mysql.R
@@ -8,9 +8,6 @@ test_that("dm_sql()", {
   # Need skip in every test block, unfortunately
   skip_if_src_not("mysql")
 
-  # https://github.com/tidyverse/dbplyr/pull/1190
-  skip_if(is(my_test_con(), "MySQLConnection") && packageVersion("dbplyr") < "2.4.0")
-
   expect_snapshot({
     dm_for_filter_df() %>%
       dm_sql(my_test_con())

diff --git a/tests/testthat/test-postgres.R b/tests/testthat/test-postgres.R
@@ -8,9 +8,6 @@ test_that("dm_sql()", {
   # Need skip in every test block, unfortunately
   skip_if_src_not("postgres")
 
-  # https://github.com/tidyverse/dbplyr/pull/1190
-  skip_if(is(my_test_con(), "MySQLConnection"))
-
   expect_snapshot({
     dm_for_filter_df() %>%
       dm_sql(my_test_con())

diff --git a/tests/testthat/test-sqlite.R b/tests/testthat/test-sqlite.R
@@ -8,9 +8,6 @@ test_that("dm_sql()", {
   # Need skip in every test block, unfortunately
   skip_if_src_not("sqlite")
 
-  # https://github.com/tidyverse/dbplyr/pull/1190
-  skip_if(is(my_test_con(), "MySQLConnection"))
-
   expect_snapshot({
     dm_for_filter_df() %>%
       dm_sql(my_test_con())