Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions: Drop Ubuntu 20.04 #6568

Open
wants to merge 1 commit into
base: 8.4.x
Choose a base branch
from
Open

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Jan 20, 2025

Ubuntu 20.04 going away by 1 April. Brownouts starting in March. https://github.blog/changelog/2025-01-15-github-actions-ubuntu-20-runner-image-brownout-dates-and-other-breaking-changes/

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • No dependency changes or docs or tests etc
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@MetRonnie MetRonnie added small infrastructure GH Actions, Codecov etc. labels Jan 20, 2025
@MetRonnie MetRonnie self-assigned this Jan 20, 2025
@oliver-sanders
Copy link
Member

I'm not sure this action will actually protect us from much once the image is updated (again).

Plz hold off on this until March so we use the older image for as long as we are able. After that we might just have to drop the check :(

@MetRonnie
Copy link
Member Author

How do we know if the test is valid or not on Ubuntu 22?

@oliver-sanders
Copy link
Member

It's not really valid on 20, but it's better than nothing.

It restricts the manylinux versions that can be used to install wheels. It will fallback to building from source if that fails, this build may fail on older boxes for various reasons. Ideally we would use an ancient SLES image, but we don't have access to that, so we used an ancient Ubuntu image which was close enough. But the more we upgrade the box, the more invalid the comparison becomes and the less protection the test offers.

@MetRonnie
Copy link
Member Author

Of the pip packages installed in the Python 3.7 run, it looks like the following are built from source on Ubuntu 22:

  • psutil
  • pyzmq
  • numpy
  • PyYAML

The rest of them are either *-any.whl or manylinux:

  • Pillow-9.5.0-cp37-cp37m-manylinux_2_28_x86_64.whl
  • matplotlib-3.5.3-cp37-cp37m-manylinux_2_5_x86_64.manylinux1_x86_64.whl
  • coverage-7.2.7-cp37-cp37m-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_17_x86_64.manylinux2014_x86_64.whl
  • kiwisolver-1.4.5-cp37-cp37m-manylinux_2_5_x86_64.manylinux1_x86_64.whl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure GH Actions, Codecov etc. small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants