Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove issue templates #5365

Merged
merged 3 commits into from
Feb 27, 2023
Merged

remove issue templates #5365

merged 3 commits into from
Feb 27, 2023

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Feb 14, 2023

Spotted whilst trawling other folks repos, if you create a repo called ".github" you can configure orginisational defaults for things like issue templates.

[edit] actually there was an issue for this which I had totally forgotten about:
cylc/cylc-admin#127

https://github.com/cylc/.github

When these templates are removed from cylc-flow the orginisation defaults will kick in.

See what they look like here: https://github.com/cylc/.github/issues/new/choose

I've used these templates to raise awareness of Discourse by linking through to the site.

(note the report security vulnerability template is GitHub defined)

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg and conda-environment.yml.
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

* Defaults can now be centrally configured in
  https://github.com/cylc/.github
@oliver-sanders oliver-sanders added this to the cylc-8.2.0 milestone Feb 14, 2023
@oliver-sanders oliver-sanders self-assigned this Feb 20, 2023
Comment on lines -6 to -8
Github](https://github.com/cylc/cylc-flow/issues). Give the Cylc version
affected by the bug (you should test the latest release if possible) and a
recipe to reproduce the problem.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This advice is now present in the issue templates.

Comment on lines -13 to -14
Github](https://github.com/cylc/cylc-flow/issues). Describe your use case in
detail.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This advice is now present in the issue templates.

Comment on lines -18 to -19
All contributions to Cylc are made via Pull Requests against the *master*
branch of [cylc/cylc-flow](https://github.com/cylc/cylc-flow). Non-trivial
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer true.

Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hjoliver hjoliver merged commit c7fb807 into cylc:master Feb 27, 2023
@wxtim
Copy link
Member

wxtim commented Feb 27, 2023

I cannot see the .github repo? Presumably because I'm a member and not an owner?

@oliver-sanders oliver-sanders deleted the issue-templates branch February 27, 2023 11:13
@oliver-sanders
Copy link
Member Author

Whoops, made it public: https://github.com/cylc/.github/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants