Trigger when paused #790
Merged
Trigger when paused #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MetRonnie
reviewed
Jan 8, 2025
There was a problem hiding this comment.
Not a big deal, but I think this would be more "concise" if the workflow was running when the GIF starts.
Also, your GIFs appear to be slightly yellow?
There was a problem hiding this comment.
I have no idea what's causing that "yellowing" strange (custom CSS / browser settings?).
I think this example could be a tad simpler, the trigger operation is kinda lost in play/pause/graph-pan operations. Suggest:
- Use the tree view and a workflow simple enough to fit on one page (no panning/scrolling, will make it clearer when the GIF loops).
- Start with the workflow running (as suggested above).
- Pause the workflow and observe that tasks aren't running.
- Trigger one task and watch it run.
There was a problem hiding this comment.
Yellowing is my desktop theme.
It is playing to start with.
2 tasks
wxtim
force-pushed
the
trigger-when-paused
branch
from
8a7a5c8 to
01dd488
Compare
oliver-sanders
approved these changes
Jan 8, 2025
wxtim
force-pushed
the
trigger-when-paused
branch
from
6f438b7 to
0e213bf
Compare
MetRonnie
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of #778 with spelling fix and updated animation, but not reference/changes, all of which I'm going to do as a single PR to avoid need to deconflict
Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.