Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Kubernetes 1.27 #672

Merged
merged 5 commits into from
Nov 30, 2023
Merged

Support Kubernetes 1.27 #672

merged 5 commits into from
Nov 30, 2023

Conversation

masa213f
Copy link
Contributor

@masa213f masa213f commented Nov 17, 2023

@masa213f masa213f self-assigned this Nov 17, 2023
@masa213f masa213f changed the title Update go dependencies and go minimal version Support Kubernetes 1.27 Nov 17, 2023
Signed-off-by: Masayuki Ishii <[email protected]>
@masa213f masa213f force-pushed the k8s-1.27 branch 2 times, most recently from bce82f4 to 8d93266 Compare November 29, 2023 05:14
@@ -364,7 +364,6 @@ func KubeletServiceParams(n *cke.Node, params cke.KubeletParams) cke.ServicePara
"--kubeconfig=/etc/kubernetes/kubelet/kubeconfig",
"--hostname-override=" + n.Nodename(),
}
args = append(args, "--container-runtime=remote")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--container-runtime is removed.
kubernetes/kubernetes#114017

@@ -22,7 +22,6 @@ rules:
- apiGroups:
- ""
resources:
- endpoints
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From v1.11.0, CoreDNS does not watch Endpoints.
coredns/coredns#6147

Signed-off-by: Masayuki Ishii <[email protected]>
Signed-off-by: Masayuki Ishii <[email protected]>
Signed-off-by: Masayuki Ishii <[email protected]>
Copy link
Contributor

@terassyi terassyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masa213f masa213f merged commit cdf3a1f into main Nov 30, 2023
7 checks passed
@masa213f masa213f deleted the k8s-1.27 branch November 30, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants