Add register-month and retire-month labels
#663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymmt2005
reviewed
Sep 8, 2023
sabakan/generator.go
Outdated
Comment on lines
55
to
56
| n.Labels["cke.cybozu.com/retire-date"] = m.Spec.RetireDate.Format("2006-01") | ||
| n.Labels["cke.cybozu.com/register-date"] = m.Spec.RegisterDate.Format("2006-01") |
There was a problem hiding this comment.
Looks like a month rather than a date.
zoetrope
force-pushed
the
register-retire-date-label
branch
from
472ae42
to
b9ab8b7
Compare
zoetrope
changed the title
register-date and retire-date labelsregister-month and retire-month labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add registration and retiring months to node labels.
These labels will be helpful in scheduling pods.