Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard condition to check node clock is not zero, to suppress "No clock received" error from ros2_control. #1027

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ralphieraccoon
Copy link
Contributor

@ralphieraccoon ralphieraccoon commented Jan 27, 2025

Description
This adds a guard condition to Ros2Control::step() to check node clock is not zero, fixes the "No clock received" error. Basically stops a step update occurring unless the clock is not zero.

Affected Packages
List of affected packages:

  • webots_ros2_control

@ralphieraccoon ralphieraccoon added the bug Something isn't working label Jan 27, 2025
@ralphieraccoon ralphieraccoon marked this pull request as ready for review January 27, 2025 16:57
@skpawar1305
Copy link
Contributor

this might cause issues when simulation is running at realtime, can you check?

@skpawar1305
Copy link
Contributor

I meant in webots with sim time as false

@ralphieraccoon
Copy link
Contributor Author

I ran ros2 launch webots_ros2_epuck robot_launch.py "use_sim_time:=false" and sent a command to /cmd_vel. The video is below, it looks the same as if I run it with "use_sim_time:=true"

tmpwve0tke2_world_with_URDF_robot-10MB.mp4

Does that look right to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants